-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix supertibble label #179
Conversation
I think this looks awesome! One tiny thing: please capitalize the final R in REDCapTidieR. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me, one minor comment about roxygen docs. I can't think of much else right now to apply this to, but it's good to know we can make use of it.
Looks like the failure is a snapshot update which is expected. The warnings weren't appearing for me but seem to be related to REDCapTidieR/R/clean_redcap_long.R Lines 87 to 88 in 5ab694e
|
Good catch! |
I think I fixed this in the last commit. I'll keep an eye on the CI. I went ahead and just upgraded everything in our |
Description
This PR fixes a bug that was causing one of our error messages to print incorrectly. Since it required learning a bit about custom print methods I also added a customization to the header when our supertibbles print. Let me know if you think we should keep it.
Proposed Changes
vec_ptype_abbr.redcap_supertbl()
method so that objects of the supertibble type get abbreviated tosuprtbl
in cli messages.vctrs
vignette which advises keeping labels to 6 characters because these labels also appear when objects are elements of atibble
orlist
tbl_sum.redcap_supertbl()
method so that printed supertibbles include a header with the object type and number of instrumentsutility/refresh.R
Error Message Fix
Old
New
Custom Header
Old
New
Issue Addressed
Closes #157
PR Checklist
Before submitting this PR, please check and verify below that the submission meets the below criteria:
.RDS
) updated underinst/testdata/create_test_data.R
usethis::use_version()
Code Review
This section to be used by the reviewer and developers during Code Review after PR submission
Code Review Checklist