Skip to content

Jiefu Ling & Alex Fu #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Jiefu Ling & Alex Fu #10

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ab04c06
Update README.md
Jeff-Ling Sep 20, 2023
da638cf
Update README.md
Jeff-Ling Sep 20, 2023
0e13171
Update README.md
Jeff-Ling Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,12 @@ Extra credit if you can find all FIVE bugs.
- In the README, create a link to your shader toy solution with the bugs corrected
- In the README, describe each bug you found and include a sentence about HOW you found it.
- Make sure all three of your shadertoys are set to UNLISTED or PUBLIC (so we can see them!)

# Jiefu Ling & Alex Fu
- Team members: Jiefu Ling, Alex Fu
- [Link to solution](https://www.shadertoy.com/view/cd3yR2)
- Bugs:
1. vec uv2. It missed the 2 after vec2. I found this error through the compiler error.
2. H *= len * iResolution.x / iResolution.x; It should be H *= len * iResolution.x / iResolution.y; I found this error by checking line by line. Aspect should be x / y not x / x;
3. raycast(uv, dir, eye, ref); It should be raycast(uv2, dir, eye, ref); I found this error by checking through the main process of the shader.
4. dir = reflect(eye, nor); It should be dir = reflect(dir, nor); Because the reflection seems not correct.