Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lab02 | Aboudi Rai #21

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Lab02 | Aboudi Rai #21

wants to merge 1 commit into from

Conversation

aykae
Copy link

@aykae aykae commented Sep 20, 2023

Aboudi Rai | Submission:

Result

My Debugging Scene

Bugs

  1. Line 97: There was a syntax error where a vec2 was accidentally written as vec.
  2. Line 100: uv was fed into raycast instead of uv2
  3. Line 11: Height was not being multiplied by correct aspect ratio. Switched to H *= len * iResolution.x / iResolution.y
  4. Line 18: Increased iteration count in march(...) to 256 to allow all parts of the floor to be hit.
  5. Line 75: reflection was erroneously done about eye and nor rather than dir and nor.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant