-
Notifications
You must be signed in to change notification settings - Fork 54
Project 4: Griffin Evans #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
grievans
wants to merge
30
commits into
CIS5650-Fall-2025:main
Choose a base branch
from
grievans:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grievans
commented
Oct 18, 2025
- https://github.com/grievans/Project4-WebGPU-Forward-Plus-and-Clustered-Deferred/tree/main
- Implemented 3 modes of rendering using WebGPU:
- Naïve forward rendering
- Forward+ rendering
- Clustered Deferred rendering
- Feedback:
- There were a few bugs in the base code which made setting up the Github deployment and doing performance analysis difficult
- The stats.js gui used is meant to display run time in milliseconds, but the timer used only actually times the CPU-side calls to start up the shaders used and doesn't actually wait for the GPU-side execution to finish, meaning by default it appears to always output a time of 0 or occasionally 1 millisecond (since the CPU-side code finishes almost immediately).
- For some reason, the lightRadius constant does not pass in to the shaders properly when deployed on the web, while it does when running locally. I fixed this in my code through hard-coding its value when used in the shaders.
- I felt relatively lost initially, mostly about the API calls for the setting up of the pipelines and buffers; I think something like a simple intro project to experiment with similar to what we have in Project 0 for CUDA could be a beneficial addition at least as an optional component just to ease into the language more.
- There were a few bugs in the base code which made setting up the Github deployment and doing performance analysis difficult
…machine to evaluate fully
…the-last-minute editing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.