Emily Vo - Project 1, Noise#10
Open
emily-vo wants to merge 6 commits intoCIS700-Procedural-Graphics:masterfrom
Open
Emily Vo - Project 1, Noise#10emily-vo wants to merge 6 commits intoCIS700-Procedural-Graphics:masterfrom
emily-vo wants to merge 6 commits intoCIS700-Procedural-Graphics:masterfrom
Conversation
austinEng
reviewed
Jan 26, 2017
Contributor
austinEng
left a comment
austinEng
left a comment
There was a problem hiding this comment.
Nice job. I noticed your color values tend to all go to white as you increase the number of octaves. This is probably because your octaves are stacking up to values greater than one. You can probably use the number of octaves to divide the color (or some other function) so that you don't get values too large.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http://www.emilyhvo.com/Project1-Noise/