EllenDuong_Project1Noise_Submission#28
Open
eldu wants to merge 5 commits intoCIS700-Procedural-Graphics:masterfrom
Open
EllenDuong_Project1Noise_Submission#28eldu wants to merge 5 commits intoCIS700-Procedural-Graphics:masterfrom
eldu wants to merge 5 commits intoCIS700-Procedural-Graphics:masterfrom
Conversation
Author
austinEng
reviewed
Jan 25, 2017
Contributor
austinEng
left a comment
austinEng
left a comment
There was a problem hiding this comment.
Nice job! Next time be sure to include a README.md. Try not to commit the pdf of the lecture slides :P
| }, | ||
| persistence: { | ||
| type: "f", | ||
| value: 4.0 |
Contributor
There was a problem hiding this comment.
This value should probably be bounded from 0 to 1. Greater than 1 and your function grows out of control as you increase octaves.
| varying float vTime; | ||
|
|
||
| void main() { | ||
| gl_FragColor = vec4(vNormal, 1.0); |
Contributor
There was a problem hiding this comment.
Color should be based on a noise function as well!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.