Skip to content

Fix Windows/macOS builds, log formatting, markdown rendering, and user mentions #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CJFWeatherhead merged 9 commits into from
Oct 31, 2025
Merged

Fix Windows/macOS builds, log formatting, markdown rendering, and user mentions #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
79d3061
Initial plan
Copilot Oct 31, 2025
7b72d08
Fix build, log formatting, markdown, and mentions
Copilot Oct 31, 2025
e79eb0d
Documentation cleanup and test improvements
Copilot Oct 31, 2025
51a0468
Update CHANGELOG.md with all fixes and improvements
Copilot Oct 31, 2025
151e455
Address code review feedback
Copilot Oct 31, 2025
e989fcb
Improve robustness based on code review
Copilot Oct 31, 2025
1cb3933
Fix macOS build: use homebrew libolm instead of building from source
Copilot Oct 31, 2025
f92f291
Fix test_get_display_name to expect full Matrix IDs
Copilot Oct 31, 2025
b30a743
Fix shellcheck warning SC2129 in macOS build step
Copilot Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,17 @@ jobs:
# Download and build libolm (pinned to v3.2.16 for reproducible builds)
git clone --branch 3.2.16 --depth 1 https://gitlab.matrix.org/matrix-org/olm.git C:\olm
cd C:\olm

# Patch CMakeLists.txt to require CMake 3.5+ (for compatibility with modern CMake)
$originalContent = Get-Content CMakeLists.txt -Raw
$patchedContent = $originalContent -replace 'cmake_minimum_required\(VERSION [0-9]+\.[0-9]+(?:\.[0-9]+)?\)', 'cmake_minimum_required(VERSION 3.5)'
Copy link

Copilot AI Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The regex pattern uses PowerShell string escaping but the parentheses in cmake_minimum_required are not escaped. While this works, it's more correct to escape them as \( and \) for clarity, or use a verbatim string pattern. Consider: 'cmake_minimum_required\\(VERSION [0-9]+\\.[0-9]+(?:\\.[0-9]+)?\\)' for better maintainability.

Suggested change
$patchedContent = $originalContent -replace 'cmake_minimum_required\(VERSION [0-9]+\.[0-9]+(?:\.[0-9]+)?\)', 'cmake_minimum_required(VERSION 3.5)'
$patchedContent = $originalContent -replace 'cmake_minimum_required\\(VERSION [0-9]+\\.[0-9]+(?:\\.[0-9]+)?\\)', 'cmake_minimum_required(VERSION 3.5)'

Copilot uses AI. Check for mistakes.
if ($patchedContent -ne $originalContent) {
Set-Content CMakeLists.txt $patchedContent
Write-Host "Successfully patched CMakeLists.txt to require CMake 3.5+"
} else {
Write-Host "Warning: CMakeLists.txt patch pattern not found, continuing anyway..."
}

cmake -S . -B build `
-DCMAKE_INSTALL_PREFIX=C:\olm-install `
-DCMAKE_BUILD_TYPE=Release `
Expand Down Expand Up @@ -353,7 +364,13 @@ jobs:
run: |
# Detect homebrew prefix (Apple Silicon uses /opt/homebrew, Intel uses /usr/local)
HOMEBREW_PREFIX=$(brew --prefix)
echo "PKG_CONFIG_PATH=${HOMEBREW_PREFIX}/lib/pkgconfig:${PKG_CONFIG_PATH}" >> "$GITHUB_ENV"

# Set environment variables for subsequent steps
{
echo "PKG_CONFIG_PATH=${HOMEBREW_PREFIX}/lib/pkgconfig:${PKG_CONFIG_PATH}"
echo "CFLAGS=-I${HOMEBREW_PREFIX}/include"
echo "LDFLAGS=-L${HOMEBREW_PREFIX}/lib"
} >> "$GITHUB_ENV"

- name: Install dependencies
run: |
Expand Down
328 changes: 0 additions & 328 deletions AUDIT_SUMMARY.md
View file
Open in desktop

This file was deleted.

Loading
Loading