fix: Resolve macOS and Windows build failures in workflow and installation guide #93
+44
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installing from source on macOS,
pip install -r requirements.txtfails with CMake compatibility errors becausepython-olmbundles an outdated libolm (requires CMake < 3.5, incompatible with modern CMake). Additionally, the CI/CD workflow itself was failing on both Windows and macOS builds.Changes
brew install libolm pkg-config cmakebefore Python dependency installationolm_static.lib- CMake actually createsolm.lib, notolm_static.libCMAKE_ARGS=-DCMAKE_POLICY_VERSION_MINIMUM=3.5to prevent python-olm from building bundled libolm sourceContext
The CI/CD workflow was failing on both Windows and macOS builds:
Windows: The workflow expected
olm_static.libbut CMake createsolm.libwhenBUILD_SHARED_LIBS=OFFmacOS: Despite installing libolm via Homebrew and setting
PKG_CONFIG_PATH, python-olm was still attempting to build its bundled source, causing:Installing libolm systemwide and setting appropriate environment variables forces
python-olmto link against the system library instead of building its bundled source. This fix applies to both user installations and CI/CD builds.Original prompt
Mac OS build failing:
Downloading python-olm-3.2.16.tar.gz (2.7 MB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 2.7/2.7 MB 94.9 MB/s 0:00:00
Installing build dependencies: started
Installing build dependencies: finished with status 'done'
Getting requirements to build wheel: started
Getting requirements to build wheel: finished with status 'error'
error: subprocess-exited-with-error
× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> [53 lines of output]
CMake Error at CMakeLists.txt:1 (cmake_minimum_required):
Compatibility with CMake < 3.5 has been removed from CMake.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.