Fix Windows build: build libolm as shared library (DLL)

[Copilot]

Windows build was failing because libolm was being built as a static library instead of a shared library (DLL). Python-olm on Windows requires a DLL with an import library for proper linking and runtime loading.

Changes

• Changed BUILD_SHARED_LIBS from OFF to ON in CMake configuration
• Added verification for both olm.dll (shared library) and olm.lib (import library)
• Added C:\olm-install\bin to PATH for runtime DLL discovery
• Updated comments to reflect correct build configuration

Root Cause
On Windows, CMake with:

• BUILD_SHARED_LIBS=OFF creates only olm.lib (static library)
• BUILD_SHARED_LIBS=ON creates olm.dll (shared library) + olm.lib (import library)

Python extensions on Windows require shared libraries (DLLs), not static libraries.

Before

cmake -S . -B build `
  -DCMAKE_INSTALL_PREFIX=C:\olm-install `
  -DCMAKE_BUILD_TYPE=Release `
  -DBUILD_SHARED_LIBS=OFF  # Creates static library

After

cmake -S . -B build `
  -DCMAKE_INSTALL_PREFIX=C:\olm-install `
  -DCMAKE_BUILD_TYPE=Release `
  -DBUILD_SHARED_LIBS=ON  # Creates shared library (DLL)

# Verify both files exist
if (-not (Test-Path "C:\olm-install\bin\olm.dll")) {
  Write-Error "ERROR: olm.dll not found"
  exit 1
}
if (-not (Test-Path "C:\olm-install\lib\olm.lib")) {
  Write-Error "ERROR: olm.lib not found"
  exit 1
}

# Add bin to PATH for runtime DLL discovery
echo "PATH=C:\olm-install\bin;$env:PATH" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append

Original prompt

Windows build failing:

C:\olm\tests\test_pk.cpp(219,17): warning C4996: 'strdup': The POSIX name for this item is deprecated. Instead, use the ISO C and C++ conformant name: _strdup. See online help for details. [C:\olm\build\tests\test_pk.vcxproj]
test_pk.vcxproj -> C:\olm\build\tests\Release\test_pk.exe
Building Custom Rule C:/olm/tests/CMakeLists.txt
test_ratchet.cpp
test_ratchet.vcxproj -> C:\olm\build\tests\Release\test_ratchet.exe
Building Custom Rule C:/olm/tests/CMakeLists.txt
test_sas.cpp
test_sas.vcxproj -> C:\olm\build\tests\Release\test_sas.exe
Building Custom Rule C:/olm/tests/CMakeLists.txt
test_session.cpp
test_session.vcxproj -> C:\olm\build\tests\Release\test_session.exe
Building Custom Rule C:/olm/CMakeLists.txt
-- Installing: C:/olm-install/lib/olm.lib
-- Installing: C:/olm-install/include/olm/olm.h
-- Installing: C:/olm-install/include/olm/olm_export.h
-- Installing: C:/olm-install/include/olm/outbound_group_session.h
-- Installing: C:/olm-install/include/olm/inbound_group_session.h
-- Installing: C:/olm-install/include/olm/pk.h
-- Installing: C:/olm-install/include/olm/sas.h
-- Installing: C:/olm-install/include/olm/error.h
-- Installing: C:/olm-install/lib/cmake/Olm/OlmTargets.cmake
-- Installing: C:/olm-install/lib/cmake/Olm/OlmTargets-release.cmake
-- Installing: C:/olm-install/lib/cmake/Olm/OlmConfig.cmake
-- Installing: C:/olm-install/lib/cmake/Olm/OlmConfigVersion.cmake
Contents of C:\olm-install\lib:

Directory: C:\olm-install\lib

Mode LastWriteTime Length Name

---

d---- 10/31/2025 4:13 PM cmake
-a--- 10/31/2025 4:13 PM 496270 olm.lib

Directory: C:\olm-install\lib\cmake

Mode LastWriteTime Length Name

---

d---- 10/31/2025 4:13 PM Olm

Directory: C:\olm-install\lib\cmake\Olm

Mode LastWriteTime Length Name

---

-a--- 10/31/2025 4:12 PM 312 OlmConfig.cmake
-a--- 10/31/2025 4:12 PM 2830 OlmConfigVersion.cmake
-a--- 10/31/2025 4:12 PM 826 OlmTargets-release.cmake
-a--- 10/31/2025 4:12 PM 4195 OlmTargets.cmake
Write-Error: ERROR: olm_static.lib not found in C:\olm-install\lib. Build cannot continue.
Error: Process completed with exit code 1.

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[CJFWeatherhead]

@copilot This doesn't fix the issue in the last build and release workflow, all this does is return that the process completes correctly without error

[Copilot]

@copilot This doesn't fix the issue in the last build and release workflow, all this does is return that the process completes correctly without error

I need to understand the actual failure better. Looking at the error message, it showed that olm.lib was successfully created (496270 bytes), but the workflow was checking for olm_static.lib.

Can you clarify what the actual issue is? Is the problem that:

1. The olm.lib that's being created is the wrong type (shared vs static)?
2. There's a subsequent build failure when trying to use olm.lib?
3. Something else?

If you have logs from the actual build failure (not just the library check), that would help me identify the root cause.

@copilot This doesn't fix the issue in the last build and release workflow, all this does is return that the process completes correctly without error

You're absolutely right. I've fixed the actual issue now in commit aaf56ea.

The problem was that the workflow was building libolm as a static library (BUILD_SHARED_LIBS=OFF), but python-olm on Windows requires a shared library (DLL).

The fix changes BUILD_SHARED_LIBS from OFF to ON, which creates:

• olm.dll - the shared library
• olm.lib - import library for linking

Also added C:\olm-install\bin to PATH so the DLL can be found at runtime.

[EdGeraghty]

@CJFWeatherhead libolm is deprecated. Look to https://github.com/matrix-org/vodozemac