Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply pre-commit hooks and add appropriate GitHub workflow #935

Closed
wants to merge 16 commits into from

Conversation

peanutfun
Copy link
Member

@peanutfun peanutfun commented Aug 9, 2024

Changes proposed in this PR:

  • Add GitHub workflow for checking pre-commit hooks
  • Apply pre-commit hooks to repository

Things to note for reviewers:

  • To review, follow the commits: The changes apart from re-formatting everything are
    • Newly added GitHub workflow for pull requests: Run pre-commit hooks on changed files (Executes in 2m to 20sec, thanks to caching)
    • Fix circular imports introduced by "mindless" isort sorting
  • There are instances in the tests where the formatting could have been omitted (e.g., for larger arrays of test data). I simply did not care for time reasons 🤷

This PR fixes #

PR Author Checklist

PR Reviewer Checklist

@peanutfun peanutfun changed the title Add GitHub workflow for checking pre-commit hooks Apply pre-commit hooks and add appropriate GitHub workflow Aug 9, 2024
Base automatically changed from pre-commit-configuration to develop October 20, 2024 13:14
@emanuel-schmid
Copy link
Collaborator

replaced by idem-potent develop-black branch

@peanutfun
Copy link
Member Author

@emanuel-schmid If I see this correctly, the workflow I added in this branch was not added to develop-black.

@emanuel-schmid
Copy link
Collaborator

@peanutfun oops! 😊 sorry I missed that. Will add it in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants