Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eccodes dependency update #947

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Conversation

emanuel-schmid
Copy link
Collaborator

@emanuel-schmid emanuel-schmid commented Sep 12, 2024

Changes proposed in this PR:

  • optionally change variable names of eccodes 'gust' variable to allow updating to eccodes > 2.27

This PR fixes #678

PR Author Checklist

PR Reviewer Checklist

@emanuel-schmid emanuel-schmid changed the title eccodes changed variable names: i.p., gust -> i10fg eccodes dependency update Sep 12, 2024
@mmyrte
Copy link
Collaborator

mmyrte commented Sep 13, 2024

Hi @emanuel-schmid, I'm not at all in the know about eccodes and the grib-files being read. I avoided adding eccodes to the dependencies in summer 2020 because it's not pure Python, and because I was only reading minimal amounts of bufr files. I suppose that @ThomasRoosli is much closer to the subject at hand...

@emanuel-schmid
Copy link
Collaborator Author

@mmyrte 👍 fair enough. thanks for the note!

@emanuel-schmid emanuel-schmid removed the request for review from mmyrte September 13, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants