Skip to content

Commit

Permalink
bp/Request: initializer stateless
Browse files Browse the repository at this point in the history
The initializer for this field has always been missing, but I thought
that was okay because it was not used before it was initialized by
DetermineSession(), but if ParseRequestUri() fails, a "400 Bad
Request" response was generated to early.

The assertion failure never occurred memory poisoning implicitly
initialized this field to `true`, but commit
36422d7 disabled memory poisoning.
  • Loading branch information
MaxKellermann committed Jan 15, 2025
1 parent 0606e0a commit 2198d01
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion debian/changelog
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
cm4all-beng-proxy (19.1) unstable; urgency=low

*
* bp: fix crash due to uninitialized variable

--

Expand Down
2 changes: 1 addition & 1 deletion src/bp/Request.hxx
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,7 @@ private:
* disabled? This is initialized by DetermineSession(), and
* may be disabled later by HandleTranslatedRequest().
*/
bool stateless;
bool stateless = true;

bool send_session_cookie = false;

Expand Down

0 comments on commit 2198d01

Please sign in to comment.