Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter/Sorting persistence and altering navigation logic #113

Merged
merged 3 commits into from
Dec 3, 2023
Merged

Filter/Sorting persistence and altering navigation logic #113

merged 3 commits into from
Dec 3, 2023

Conversation

Sami-Jagirdar
Copy link
Contributor

Describe your changes

This PR accomplishes the following:

  • Mainly changed the navigation logic which automatically ensures persistence of sorting/filtering when navigating between fragments
  • Added a utility method for when navigating using the bottom navbar
  • Added goBack() method wherever possible to simply pop fragments off the stack instead of creating new ones

Issue ticket number and link

This PR addresses: #<link_to_issue>

Checklist before requesting a review

  • I have performed a self-review of my code
  • Necessary java docs are present

Screenshots (if applicable)

e.g. UI screenshots, UML screenshots, etc

ldbonkowski
ldbonkowski approved these changes Dec 3, 2023
View reviewed changes
Copy link
Contributor

@ldbonkowski ldbonkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beauty LGTM!

MatthewNeufeld
MatthewNeufeld approved these changes Dec 3, 2023
View reviewed changes
Copy link
Contributor

@MatthewNeufeld MatthewNeufeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @Sami-Jagirdar. LGTM!!!!!!

@Sami-Jagirdar
Merge branch 'main' into persist
09f9d59 
# Conflicts:
#	app/src/main/java/com/example/househomey/MainActivity.java
#	app/src/main/java/com/example/househomey/SelectFragment.java
#	app/src/main/java/com/example/househomey/utils/FragmentUtils.java
owencooke
owencooke approved these changes Dec 3, 2023
View reviewed changes
Copy link
Contributor

@owencooke owencooke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, very well done. Nav should be much more efficient now

@Sami-Jagirdar Sami-Jagirdar merged commit d96d9a0 into main Dec 3, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatthewNeufeld MatthewNeufeld MatthewNeufeld approved these changes

@owencooke owencooke owencooke approved these changes

@ldbonkowski ldbonkowski ldbonkowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sami-Jagirdar @ldbonkowski @owencooke @MatthewNeufeld