Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tags + keywords -> case insensitive & can't add the same keyword more than once #115

Merged
merged 9 commits into from
Dec 3, 2023
Merged

Tags + keywords -> case insensitive & can't add the same keyword more than once #115

merged 9 commits into from
Dec 3, 2023

Conversation

MatthewNeufeld
Copy link
Contributor

@MatthewNeufeld MatthewNeufeld commented Dec 3, 2023 •
edited
Loading

Describe your changes

This PR accomplishes the following:

  • Made it so that no matter the user's casing scheme, each tag label is automatically converted to initial case.
  • Did the same thing with keyword labels ^
  • Made it so that the user can't add the same keyword multiple times

Issue ticket number and link

This PR addresses: #99

Checklist before requesting a review

  • I have performed a self-review of my code

@MatthewNeufeld MatthewNeufeld changed the title New tag case insensitive Tags + keywords -> case insensitive & can't add the same keyword more than once Dec 3, 2023
Sami-Jagirdar
Sami-Jagirdar approved these changes Dec 3, 2023
View reviewed changes
Copy link
Contributor

@Sami-Jagirdar Sami-Jagirdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ldbonkowski
ldbonkowski approved these changes Dec 3, 2023
View reviewed changes
Copy link
Contributor

@ldbonkowski ldbonkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MatthewNeufeld MatthewNeufeld merged commit 73f0636 into main Dec 3, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonio2uofa antonio2uofa antonio2uofa approved these changes

@ldbonkowski ldbonkowski ldbonkowski approved these changes

@Sami-Jagirdar Sami-Jagirdar Sami-Jagirdar approved these changes

@jdrco jdrco Awaiting requested review from jdrco

@owencooke owencooke Awaiting requested review from owencooke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MatthewNeufeld @Sami-Jagirdar @ldbonkowski @antonio2uofa