-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User profile testing #116
User profile testing #116
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests looks great, just some comments about using util functions that we already have
app/src/androidTest/java/com/example/househomey/SignInFragmentTest.java
Outdated
Show resolved
Hide resolved
app/src/androidTest/java/com/example/househomey/SignInFragmentTest.java
Outdated
Show resolved
Hide resolved
app/src/androidTest/java/com/example/househomey/SignUpFragmentTest.java
Outdated
Show resolved
Hide resolved
app/src/androidTest/java/com/example/househomey/SignUpFragmentTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Address Owen's comments and LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Describe your changes
This PR accomplishes the following:
Issue ticket number and link
This PR addresses: #<link_to_issue>
Checklist before requesting a review
Screenshots (if applicable)
e.g. UI screenshots, UML screenshots, etc