Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User profile testing #116

Merged
merged 18 commits into from
Dec 4, 2023
Merged

User profile testing #116

merged 18 commits into from
Dec 4, 2023

Conversation

antonio2uofa
Copy link
Contributor

Describe your changes

This PR accomplishes the following:

  • Description of change 1...
  • Description of change 2...

Issue ticket number and link

This PR addresses: #<link_to_issue>

Checklist before requesting a review

  • I have performed a self-review of my code
  • Necessary java docs are present
  • Necessary UML diagrams are created
  • Necessary tests are written

Screenshots (if applicable)

e.g. UI screenshots, UML screenshots, etc

Copy link
Contributor

@owencooke owencooke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests looks great, just some comments about using util functions that we already have

Copy link
Contributor

@ldbonkowski ldbonkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address Owen's comments and LGTM!

Copy link
Contributor

@owencooke owencooke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@antonio2uofa antonio2uofa merged commit 9d7a265 into main Dec 4, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants