Final UI changes #122
Merged
Final UI changes #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdrco
requested review from
Sami-Jagirdar,
ldbonkowski,
owencooke,
antonio2uofa and
MatthewNeufeld
ldbonkowski
reviewed
Dec 4, 2023
| @@ -44,15 +45,18 @@ public DeleteItemsFragment(DeleteCallBack deleteCallBack, ArrayList<Item> select | |||
| @Override | |||
| public Dialog onCreateDialog(@Nullable Bundle savedInstanceState) { | |||
| View view = getLayoutInflater().inflate(R.layout.fragment_delete_items, null); | |||
| TextView dialogMessage = view.findViewById(R.id.dialogMessage); | |||
| dialogMessage.setText("This will permanently remove the selected items from your inventory."); | |||
antonio2uofa
approved these changes
Dec 4, 2023
owencooke
requested changes
Dec 4, 2023
There was a problem hiding this comment.
Thanks again for making all these fixes @jdrco. Super clutch. A couple nitpicks from me:
- Spacing between Details and Tags sections seems pretty big
- If an item doesn't have a comment, we should probably conditionally hide the Comment header/section, to reduce the amount of empty space there, using
VISIBILITY=GONE - It might just be me, but the toolbar icons seem to have went from too big to too small. Maybe a size of 24-26dp would be better
MatthewNeufeld
requested changes
Dec 4, 2023
|
@MatthewNeufeld does this look good for fixing the Tag button alignment? Please re-approve if so |
MatthewNeufeld
approved these changes
Dec 4, 2023
Sami-Jagirdar
approved these changes
Dec 4, 2023
There was a problem hiding this comment.
@jdrco I would buy this app because of how clean the UI looks. Great job everyone!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR accomplishes the following: