Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new javadocs #125

Merged
merged 7 commits into from
Dec 4, 2023
Merged

Added new javadocs #125

merged 7 commits into from
Dec 4, 2023

Conversation

ldbonkowski
Copy link
Contributor

Describe your changes

This PR accomplishes the following:

  • Description of change 1...
  • Description of change 2...

Issue ticket number and link

This PR addresses: #<link_to_issue>

Checklist before requesting a review

  • I have performed a self-review of my code
  • Necessary java docs are present
  • Necessary UML diagrams are created
  • Necessary tests are written

Screenshots (if applicable)

e.g. UI screenshots, UML screenshots, etc

Copy link
Contributor

@Sami-Jagirdar Sami-Jagirdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My Final review :'). Approving now so you don't have to wait at the last moment. Great job (house) homies.

Copy link
Contributor

@MatthewNeufeld MatthewNeufeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing the same as @Sami-Jagirdar - giving approval now so we can merge when ready. The final approval. Thanks everyone 😭. #(house)homies4lyfe

@ldbonkowski ldbonkowski merged commit 9705c68 into main Dec 4, 2023
@ldbonkowski ldbonkowski deleted the p4-javadocs branch December 4, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants