Delete Item button #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owencooke
requested changes
Nov 8, 2023
jdrco
pushed a commit
that referenced
this pull request
Nov 9, 2023
* Delete Item button * PR changes
jdrco
added a commit
that referenced
this pull request
Nov 9, 2023
* feat: implement reset for make filter. feat: autofill existing make filter * refactor: call reset filter based on filter class type * fix: remove unused methods in make filter fragment * docs: added java docs for resetting * Espresso testing for Add Item (#47) * Working Espresso test for Add Item Uses two utility functions: 1. Sets up MainActivity with a test user 2. Added a 'waitForView' method to allow waiitng for UI to load --------- Co-authored-by: ldbonkowski <lbonkows@ualberta.ca> Co-authored-by: ldbonkowski <77549591+ldbonkowski@users.noreply.github.com> * Delete Item button (#50) * Delete Item button * PR changes * fix: reinitialize itemList array * fix: remove extra semicolon * feat: save and auto fill last make filter --------- Co-authored-by: Owen Cooke <90405643+owencooke@users.noreply.github.com> Co-authored-by: ldbonkowski <lbonkows@ualberta.ca> Co-authored-by: ldbonkowski <77549591+ldbonkowski@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR accomplishes the following:
Issue ticket number and link
This PR addresses: #16
Checklist before requesting a review
Screenshots (if applicable)
e.g. UI screenshots, UML screenshots, etc