Reset Make Filter #55
Conversation
jdrco
requested review from
Sami-Jagirdar,
ldbonkowski,
owencooke,
antonio2uofa and
MatthewNeufeld
| * @param filterClass The class of filter to reset. | ||
| */ | ||
| public void onFilterReset(Class<?> filterClass) { | ||
| for (Filter filter : appliedFilters) { |
There was a problem hiding this comment.
I believe we could just call something along the lines of appliedFilters.remove(filterinstance) no? Because appliedFilters is a Set not a List. See corresponding comment for what we would pass at the call location.
There was a problem hiding this comment.
Also, below line 99 I believe we should have applyFilters(); being called
There was a problem hiding this comment.
See my response about passing this to the callback.
Doing a simple .remove could be possible if we store the MakeFilter in the MakeFilterFragment as an attribute and then pass that MakeFilter to the callback
| */ | ||
| @Override | ||
| public void resetFilter() { | ||
| filterCallback.onFilterReset(MakeFilter.class); |
There was a problem hiding this comment.
filterCallback.onFilterReset(this);
There was a problem hiding this comment.
this here is a MakeFilterFragment and not a MakeFilter
* Working Espresso test for Add Item Uses two utility functions: 1. Sets up MainActivity with a test user 2. Added a 'waitForView' method to allow waiitng for UI to load --------- Co-authored-by: ldbonkowski <lbonkows@ualberta.ca> Co-authored-by: ldbonkowski <77549591+ldbonkowski@users.noreply.github.com>
* Delete Item button * PR changes
|
@ldbonkowski @owencooke PR is updated |
Describe your changes
This PR accomplishes the following:
Issue ticket number and link
This PR addresses: #52
Checklist before requesting a review
Screenshots (if applicable)