Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyword filter #56

Merged
merged 18 commits into from
Nov 10, 2023
Merged

Keyword filter #56

merged 18 commits into from
Nov 10, 2023

Conversation

antonio2uofa
Copy link
Contributor

@antonio2uofa antonio2uofa commented Nov 9, 2023

Describe your changes

This PR accomplishes the following:

  • Added functionality where one can call a method to update the sum and count of the list data.
  • Added the keyword filter functionality and allowed users to add/delete/reset keywords for the filter.

Issue ticket number and link

This PR addresses: #25 and #21

Checklist before requesting a review

  • I have performed a self-review of my code
  • Necessary java docs are present
  • Necessary UML diagrams are created
  • Necessary tests are written

Screenshots (if applicable)

image
image
image

@antonio2uofa antonio2uofa reopened this Nov 9, 2023
@antonio2uofa antonio2uofa marked this pull request as ready for review November 10, 2023 01:26
Copy link
Contributor

@owencooke owencooke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! One minor nitpick for the OnClick listener functions.

Also, a reoccurring issue with the FilterFragments as a whole that I've noticed while playing around is that if you click apply with nothing set, the whole list disappears. We should probably add something that either prevents this in the fragment or just keeps the whole list there if nothing is applied.

@jdrco
Copy link
Contributor

jdrco commented Nov 10, 2023

Also, a reoccurring issue with the FilterFragments as a whole that I've noticed while playing around is that if you click apply with nothing set, the whole list disappears. We should probably add something that either prevents this in the fragment or just keeps the whole list there if nothing is applied.

@owencooke @antonio2uofa we can tackle this in a separate [BUGFIX] PR

@antonio2uofa
Copy link
Contributor Author

Also, a reoccurring issue with the FilterFragments as a whole that I've noticed while playing around is that if you click apply with nothing set, the whole list disappears. We should probably add something that either prevents this in the fragment or just keeps the whole list there if nothing is applied.

@owencooke @antonio2uofa we can tackle this in a separate [BUGFIX] PR

Already done.

@owencooke
Copy link
Contributor

Fix for the empty keywords works beautiful @antonio2uofa 🙌
There's still one non-lambda kicking around in KeywordFilterFragment..... 😆

@antonio2uofa
Copy link
Contributor Author

got the last cheeky bugger. Should be all lambdas and clear skies

Copy link
Contributor

@ldbonkowski ldbonkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I have made a branch, and a PR with a couple minor changes that take advantage of a couple things in Java. If you are cool with them just approve that PR and merge it into your branch

* PR recommendations

* PR recommendations
@antonio2uofa
Copy link
Contributor Author

@ldbonkowski I squashed and merged!

Copy link
Contributor

@ldbonkowski ldbonkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@antonio2uofa antonio2uofa merged commit 56e8e3d into main Nov 10, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants