-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit Item Espresso tests and Add method to mock Items for Firestore test users #57
Conversation
@ldbonkowski here's the method to mock an item in Firebase. Lemme know ur thoughts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why things are failing on the runners, provided you can pass the checks everything looks good to me
app/src/androidTest/java/com/example/househomey/testUtils/DatabaseSetupRule.java
Outdated
Show resolved
Hide resolved
…able This is an attempt to fix issues where Espresso tries to check Views before Firebase snapshot updates
@ldbonkowski texts go green 🟢. A re-review would be lovely. I've decided to change This way we can just pass any Espresso statement(s) we like into this method, when we know there's a chance the Firebase updates might be slow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff @owencooke. Just don't forget UML diagrams :)
Describe your changes
This PR accomplishes the following:
waitForView
with a more generalwaitFor
method, to prevent tests failing due to slow Firebase updatesIssue ticket number and link
This PR addresses: #14
Checklist before requesting a review