Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: empty make filter #60

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Fix: empty make filter #60

merged 1 commit into from
Nov 10, 2023

Conversation

jdrco
Copy link
Contributor

@jdrco jdrco commented Nov 10, 2023

Describe your changes

This PR accomplishes the following:

  • Empty make filter doesn't filter the item list

Issue ticket number and link

This PR addresses: #59

Checklist before requesting a review

  • I have performed a self-review of my code
  • Necessary java docs are present
  • Necessary UML diagrams are created
  • Necessary tests are written

Screenshots (if applicable)

@jdrco jdrco linked an issue Nov 10, 2023 that may be closed by this pull request
[BUGFIX] Empty Make Filter Shouldn't Filter #59
Closed
antonio2uofa
antonio2uofa approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@antonio2uofa antonio2uofa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What an elegant solution!

Sami-Jagirdar
Sami-Jagirdar approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@Sami-Jagirdar Sami-Jagirdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, copied the code and tried it on my branch. Works!

ldbonkowski
ldbonkowski approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@ldbonkowski ldbonkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

MatthewNeufeld
MatthewNeufeld approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@MatthewNeufeld MatthewNeufeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@jdrco jdrco merged commit 981d3db into main Nov 10, 2023
1 of 2 checks passed
@jdrco jdrco deleted the empty-make-filter branch November 10, 2023 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatthewNeufeld MatthewNeufeld MatthewNeufeld approved these changes

@antonio2uofa antonio2uofa antonio2uofa approved these changes

@ldbonkowski ldbonkowski ldbonkowski approved these changes

@Sami-Jagirdar Sami-Jagirdar Sami-Jagirdar approved these changes

@owencooke owencooke Awaiting requested review from owencooke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUGFIX] Empty Make Filter Shouldn't Filter
5 participants
@jdrco @Sami-Jagirdar @ldbonkowski @antonio2uofa @MatthewNeufeld