Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Greatest espresso Tests ever #70

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Greatest espresso Tests ever #70

merged 1 commit into from
Nov 10, 2023

Conversation

ldbonkowski
Copy link
Contributor

Describe your changes

This PR accomplishes the following:

  • Description of change 1...
  • Description of change 2...

Issue ticket number and link

This PR addresses: #<link_to_issue>

Checklist before requesting a review

  • I have performed a self-review of my code
  • Necessary java docs are present
  • Necessary UML diagrams are created
  • Necessary tests are written

Screenshots (if applicable)

e.g. UI screenshots, UML screenshots, etc

jdrco
jdrco approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@jdrco jdrco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tests

Sami-Jagirdar
Sami-Jagirdar reviewed Nov 10, 2023
View reviewed changes
Copy link
Contributor

@Sami-Jagirdar Sami-Jagirdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautifuul, nothing wrong

Sami-Jagirdar
Sami-Jagirdar approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@Sami-Jagirdar Sami-Jagirdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

owencooke
owencooke approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@owencooke owencooke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOOKS AMAZING

@owencooke owencooke merged commit 9ac7080 into main Nov 10, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owencooke owencooke owencooke approved these changes

@jdrco jdrco jdrco approved these changes

@Sami-Jagirdar Sami-Jagirdar Sami-Jagirdar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ldbonkowski @Sami-Jagirdar @jdrco @owencooke