Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Espresso tests for Photos + Photo Delete Fixes #88

Merged
merged 4 commits into from
Nov 28, 2023
Merged

Add Espresso tests for Photos + Photo Delete Fixes #88

merged 4 commits into from
Nov 28, 2023

Conversation

owencooke
Copy link
Contributor

Describe your changes

This PR accomplishes the following:

  • adds Espresso tests to Add/Edit Item fragments for adding and deleting photo functionality
  • fixes issues where deleting item (individually or via multiple select) didn't delete their associated photos

Issue ticket number and link

This PR addresses: #9 #19

Checklist before requesting a review

  • I have performed a self-review of my code
  • Necessary java docs are present
  • Necessary UML diagrams are created
  • Necessary tests are written

Screenshots (if applicable)

image

@owencooke owencooke self-assigned this Nov 28, 2023
jdrco
jdrco approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@jdrco jdrco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just have a comment about adding some java docs.

app/src/androidTest/java/com/example/househomey/testUtils/TestHelpers.java Show resolved Hide resolved
ldbonkowski
ldbonkowski approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@ldbonkowski ldbonkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@owencooke owencooke merged commit 4028f20 into main Nov 28, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdrco jdrco jdrco approved these changes

@ldbonkowski ldbonkowski ldbonkowski approved these changes

Assignees

@owencooke owencooke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@owencooke @ldbonkowski @jdrco