Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINT-2550] Data Exchange Approach Marked Complete Notification #1403

Open
wants to merge 51 commits into
base: feature/MINT-2720_data_exchange
Choose a base branch
from

Conversation

OddTomBrooks
Copy link
Contributor

@OddTomBrooks OddTomBrooks commented Oct 7, 2024

MINT-2550

Description

  • Added notification for when Data Exchange Approach is marked complete

How to test this change

  1. Open Postman
  2. Create a model plan
  3. Set the Post Man user account notification preference flags to include both EMAIL and IN_APP (I do this directly in the database)
  4. Update the Data Exchange Approach section
  5. Upon setting the Marked Complete bool to true, you should see an email in Mailcatcher and a should be able to see an in-app notification by getting the user's notifications in postman

PR Author Checklist

  • I have provided a detailed description of the changes in this PR.
  • I have provided clear instructions on how to test the changes in this PR.
  • I have updated tests or written new tests as appropriate in this PR.
  • Updated the Postman Collection if necessary.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • When approving a PR, provide a reason why you're approving it
    • e.g. "Approving because I tested it locally and all functionality works as expected"
    • e.g. "Approving because the change is simple and matches the Figma design"
  • Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

OddTomBrooks and others added 30 commits July 5, 2024 02:07
* feat: added feature migration, data models, gql

* chore: updated sql queries

* feat: several major improvements to first semi-functional data exchange approach in-app notification

* chore: updated postman collection to get all notifications

* chore: updated frontend gql and backend gql for user notification preferences

* chore: added simple resolver helper to dispatch emails and email test to validate email templates

* chore: removed resolved question

* chore: Reset all frontend files to main branch as we split the frontend work to EASI-4491

* chore: reran gql gen

* chore: email unit test for data exchange approach completed

* chore: removed unnecessary Scan and Value methods

* chore: added unit test for activity data exchange complete notification

* chore: implemented resolver for data exchange approach completed notification preferences

* fix: updated various test definitions to match new user account preferences spec

* chore: removed outdated comment

* chore: updated postman collection renaming markedCompletedBy -> markedCompleteBy

* chore: converted data exchange approach complete meta to id
# Conflicts:
#	cmd/dbseed/main.go
#	cmd/test_email/main.go
#	pkg/email/template_service_impl.go
#	pkg/graph/generated/generated.go
#	src/gql/gen/graphql.ts
…ta_exchange_approach

# Conflicts:
#	MINT.postman_collection.json
#	cmd/dbseed/main.go
#	cmd/test_email/main.go
#	pkg/email/template_service_impl.go
#	pkg/graph/generated/generated.go
#	pkg/graph/resolvers/activity.resolvers.go
#	pkg/graph/resolvers/added_as_collaborator_email_test.go
#	pkg/graph/resolvers/data_exchange_approach_helper.go
#	pkg/graph/resolvers/plan_collaborator_test.go
#	pkg/graph/resolvers/resolver_test.go
#	pkg/graph/resolvers/resolver_test_utilities.go
#	pkg/graph/resolvers/user_notification_preferences.resolvers.go
#	pkg/graph/schema/types/activity.graphql
#	pkg/models/data_exchange_approach.go
#	pkg/models/data_exchange_approach_completed_activity_meta.go
#	pkg/notifications/data_exchange_approach_completed.go
#	src/gql/gen/graphql.ts
# Conflicts:
#	pkg/graph/generated/generated.go
…:CMSgov/mint-app into feature/MINT-2720_data_exchange_approach
OddTomBrooks and others added 17 commits September 30, 2024 17:27
… MarkedByDts rather than explicit boolean field
…:CMSgov/mint-app into feature/MINT-2720_data_exchange_approach

# Conflicts:
#	migrations/V176__Add_Data_Exchange_Approach.sql
* feat: WIP new data loader, not fully functioning

* feat: correct bad syntax of comment in sql statement, functioning dataloadgen loader

* feat: update model plan get by id loader

* feat: scaffolding for plan basics loader

* feat: WIP basics by model plan ID loader

* feat: add graph gophers loader v 7.1

* feat: testing using data loadgen v7 instead of normal version

* feat: v7 clear cache

* feat: v7 plan basics with new organization paradigm

* feat: organized loader a bit more

* feat: organized loader a bit more to be based on struct type then retrieval method

* chore: delete commented out code

* feat:  model plan V7 data loader version

* feat: connect new model plan data loader

* feat: remove data loadgen from library

* feat: remove old plan basics loader

* feat: wip operational solutions by needID and not needed loader

* feat: correct json struct tags to serialize keys correctly

* feat: add idea of compound key that can be used as a parameter

* chore remove compound key

* remove key and note, add notes as a comment

* feat: rename old store methods for old data loader stuff

* feat: remove old comments

* feat: move operational solution loader to the correct file

* feat: refactor operational solution by ID, and connect it to the resolvers

* feat: unit test for operational solution loader

* feat: move dataloader keys to their own file

* feat: remove unused comments and fields

* feat: return error if data loader is not on the context

* first pass generic map to hold data loader holders for instantiation

* chore: add clarifying comments to the dataloaders

* chore: replace Loaders from ctx function with error instead of bool

* feat: provide example comment to StructArrayToJSONArray

* feat: generic load method that takes the referenced loader to load it, instead of creating a method

* feat: remove load func in favor of generic

* feat: implement init methods on all loaders

* chore: fixed incorrect initialzation

* Rename/refactor LoaderConfig to LoaderWrapper, removing init() functionality and immediately-executed functions in favor of a constructor. Restructure types for each loader to have more clear names and comments

* Update comments

---------

Co-authored-by: ClayBenson94 <clay.benson@oddball.io>
…r group (#1400)

Build(deps): bump docker/bake-action in the other group

Bumps the other group with 1 update: [docker/bake-action](https://github.com/docker/bake-action).


Updates `docker/bake-action` from 5.8.0 to 5.10.0
- [Release notes](https://github.com/docker/bake-action/releases)
- [Commits](docker/bake-action@v5.8.0...v5.10.0)

---
updated-dependencies:
- dependency-name: docker/bake-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: other
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the other group with 2 updates: [golang.org/x/net](https://github.com/golang/net) and [golang.org/x/term](https://github.com/golang/term).


Updates `golang.org/x/net` from 0.29.0 to 0.30.0
- [Commits](golang/net@v0.29.0...v0.30.0)

Updates `golang.org/x/term` from 0.24.0 to 0.25.0
- [Commits](golang/term@v0.24.0...v0.25.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: other
- dependency-name: golang.org/x/term
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: other
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@OddTomBrooks OddTomBrooks requested review from a team as code owners October 7, 2024 18:01
@OddTomBrooks OddTomBrooks requested review from StevenWadeOddball, garyjzhao and patrickseguraoddball and removed request for a team October 7, 2024 18:01
dependabot bot and others added 2 commits October 7, 2024 13:25
* Build(deps): bump the other group with 18 updates

Bumps the other group with 18 updates:

| Package | From | To |
| --- | --- | --- |
| [@okta/okta-signin-widget](https://github.com/okta/okta-signin-widget) | `7.23.2` | `7.24.1` |
| [@tiptap/core](https://github.com/ueberdosis/tiptap/tree/HEAD/packages/core) | `2.7.4` | `2.8.0` |
| [@tiptap/extension-character-count](https://github.com/ueberdosis/tiptap/tree/HEAD/packages/extension-character-count) | `2.7.4` | `2.8.0` |
| [@tiptap/extension-document](https://github.com/ueberdosis/tiptap/tree/HEAD/packages/extension-document) | `2.7.4` | `2.8.0` |
| [@tiptap/extension-mention](https://github.com/ueberdosis/tiptap/tree/HEAD/packages/extension-mention) | `2.7.4` | `2.8.0` |
| [@tiptap/extension-paragraph](https://github.com/ueberdosis/tiptap/tree/HEAD/packages/extension-paragraph) | `2.7.4` | `2.8.0` |
| [@tiptap/extension-text](https://github.com/ueberdosis/tiptap/tree/HEAD/packages/extension-text) | `2.7.4` | `2.8.0` |
| [@tiptap/pm](https://github.com/ueberdosis/tiptap/tree/HEAD/packages/pm) | `2.7.4` | `2.8.0` |
| [@tiptap/react](https://github.com/ueberdosis/tiptap/tree/HEAD/packages/react) | `2.7.4` | `2.8.0` |
| [@tiptap/starter-kit](https://github.com/ueberdosis/tiptap/tree/HEAD/packages/starter-kit) | `2.7.4` | `2.8.0` |
| [@tiptap/suggestion](https://github.com/ueberdosis/tiptap/tree/HEAD/packages/suggestion) | `2.7.4` | `2.8.0` |
| [@types/lodash](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/lodash) | `4.17.9` | `4.17.10` |
| [@uswds/uswds](https://github.com/uswds/uswds) | `3.8.2` | `3.9.0` |
| [i18next](https://github.com/i18next/i18next) | `23.15.1` | `23.15.2` |
| [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) | `7.25.2` | `7.25.7` |
| [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) | `7.25.4` | `7.25.7` |
| [@cypress/code-coverage](https://github.com/cypress-io/code-coverage) | `3.13.2` | `3.13.4` |
| [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest) | `2.1.1` | `2.1.2` |


Updates `@okta/okta-signin-widget` from 7.23.2 to 7.24.1
- [Release notes](https://github.com/okta/okta-signin-widget/releases)
- [Changelog](https://github.com/okta/okta-signin-widget/blob/master/webpack.release.config.js)
- [Commits](okta/okta-signin-widget@okta-signin-widget-7.23.2...okta-signin-widget-7.24.1)

Updates `@tiptap/core` from 2.7.4 to 2.8.0
- [Release notes](https://github.com/ueberdosis/tiptap/releases)
- [Changelog](https://github.com/ueberdosis/tiptap/blob/develop/packages/core/CHANGELOG.md)
- [Commits](https://github.com/ueberdosis/tiptap/commits/@tiptap/core@2.8.0/packages/core)

Updates `@tiptap/extension-character-count` from 2.7.4 to 2.8.0
- [Release notes](https://github.com/ueberdosis/tiptap/releases)
- [Changelog](https://github.com/ueberdosis/tiptap/blob/develop/packages/extension-character-count/CHANGELOG.md)
- [Commits](https://github.com/ueberdosis/tiptap/commits/@tiptap/extension-character-count@2.8.0/packages/extension-character-count)

Updates `@tiptap/extension-document` from 2.7.4 to 2.8.0
- [Release notes](https://github.com/ueberdosis/tiptap/releases)
- [Changelog](https://github.com/ueberdosis/tiptap/blob/develop/packages/extension-document/CHANGELOG.md)
- [Commits](https://github.com/ueberdosis/tiptap/commits/@tiptap/extension-document@2.8.0/packages/extension-document)

Updates `@tiptap/extension-mention` from 2.7.4 to 2.8.0
- [Release notes](https://github.com/ueberdosis/tiptap/releases)
- [Changelog](https://github.com/ueberdosis/tiptap/blob/develop/packages/extension-mention/CHANGELOG.md)
- [Commits](https://github.com/ueberdosis/tiptap/commits/@tiptap/extension-mention@2.8.0/packages/extension-mention)

Updates `@tiptap/extension-paragraph` from 2.7.4 to 2.8.0
- [Release notes](https://github.com/ueberdosis/tiptap/releases)
- [Changelog](https://github.com/ueberdosis/tiptap/blob/develop/packages/extension-paragraph/CHANGELOG.md)
- [Commits](https://github.com/ueberdosis/tiptap/commits/@tiptap/extension-paragraph@2.8.0/packages/extension-paragraph)

Updates `@tiptap/extension-text` from 2.7.4 to 2.8.0
- [Release notes](https://github.com/ueberdosis/tiptap/releases)
- [Changelog](https://github.com/ueberdosis/tiptap/blob/develop/packages/extension-text/CHANGELOG.md)
- [Commits](https://github.com/ueberdosis/tiptap/commits/@tiptap/extension-text@2.8.0/packages/extension-text)

Updates `@tiptap/pm` from 2.7.4 to 2.8.0
- [Release notes](https://github.com/ueberdosis/tiptap/releases)
- [Changelog](https://github.com/ueberdosis/tiptap/blob/develop/packages/pm/CHANGELOG.md)
- [Commits](https://github.com/ueberdosis/tiptap/commits/@tiptap/pm@2.8.0/packages/pm)

Updates `@tiptap/react` from 2.7.4 to 2.8.0
- [Release notes](https://github.com/ueberdosis/tiptap/releases)
- [Changelog](https://github.com/ueberdosis/tiptap/blob/develop/packages/react/CHANGELOG.md)
- [Commits](https://github.com/ueberdosis/tiptap/commits/@tiptap/react@2.8.0/packages/react)

Updates `@tiptap/starter-kit` from 2.7.4 to 2.8.0
- [Release notes](https://github.com/ueberdosis/tiptap/releases)
- [Changelog](https://github.com/ueberdosis/tiptap/blob/develop/packages/starter-kit/CHANGELOG.md)
- [Commits](https://github.com/ueberdosis/tiptap/commits/@tiptap/starter-kit@2.8.0/packages/starter-kit)

Updates `@tiptap/suggestion` from 2.7.4 to 2.8.0
- [Release notes](https://github.com/ueberdosis/tiptap/releases)
- [Changelog](https://github.com/ueberdosis/tiptap/blob/develop/packages/suggestion/CHANGELOG.md)
- [Commits](https://github.com/ueberdosis/tiptap/commits/@tiptap/suggestion@2.8.0/packages/suggestion)

Updates `@types/lodash` from 4.17.9 to 4.17.10
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/lodash)

Updates `@uswds/uswds` from 3.8.2 to 3.9.0
- [Release notes](https://github.com/uswds/uswds/releases)
- [Commits](uswds/uswds@v3.8.2...v3.9.0)

Updates `i18next` from 23.15.1 to 23.15.2
- [Release notes](https://github.com/i18next/i18next/releases)
- [Changelog](https://github.com/i18next/i18next/blob/master/CHANGELOG.md)
- [Commits](i18next/i18next@v23.15.1...v23.15.2)

Updates `@babel/core` from 7.25.2 to 7.25.7
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.25.7/packages/babel-core)

Updates `@babel/preset-env` from 7.25.4 to 7.25.7
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.25.7/packages/babel-preset-env)

Updates `@cypress/code-coverage` from 3.13.2 to 3.13.4
- [Release notes](https://github.com/cypress-io/code-coverage/releases)
- [Changelog](https://github.com/cypress-io/code-coverage/blob/master/.releaserc)
- [Commits](cypress-io/code-coverage@v3.13.2...v3.13.4)

Updates `vitest` from 2.1.1 to 2.1.2
- [Release notes](https://github.com/vitest-dev/vitest/releases)
- [Commits](https://github.com/vitest-dev/vitest/commits/v2.1.2/packages/vitest)

---
updated-dependencies:
- dependency-name: "@okta/okta-signin-widget"
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: other
- dependency-name: "@tiptap/core"
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: other
- dependency-name: "@tiptap/extension-character-count"
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: other
- dependency-name: "@tiptap/extension-document"
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: other
- dependency-name: "@tiptap/extension-mention"
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: other
- dependency-name: "@tiptap/extension-paragraph"
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: other
- dependency-name: "@tiptap/extension-text"
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: other
- dependency-name: "@tiptap/pm"
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: other
- dependency-name: "@tiptap/react"
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: other
- dependency-name: "@tiptap/starter-kit"
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: other
- dependency-name: "@tiptap/suggestion"
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: other
- dependency-name: "@types/lodash"
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: other
- dependency-name: "@uswds/uswds"
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: other
- dependency-name: i18next
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: other
- dependency-name: "@babel/core"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: other
- dependency-name: "@babel/preset-env"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: other
- dependency-name: "@cypress/code-coverage"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: other
- dependency-name: vitest
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: other
...

Signed-off-by: dependabot[bot] <support@github.com>

* Added tiptap extension, removed resolution for browserslist

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Patrick Segura <patrick.segura@oddball.io>
@StevenWadeOddball StevenWadeOddball self-assigned this Oct 7, 2024
@StevenWadeOddball StevenWadeOddball changed the base branch from main to feature/MINT-2720_data_exchange October 7, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants