Skip to content
This repository has been archived by the owner on Sep 12, 2024. It is now read-only.

Add unittests for utils.py #618

Open
wants to merge 29 commits into
base: master
Choose a base branch
from
Open

Conversation

ishanrai05
Copy link
Contributor

Status

In development

Description

Added unit tests for some of the functions in utils.py

Is it backward compatible (if not, which system it affects?)

YES

Mention people to look at PRs

@sharad1126 @amaltaro

@ishanrai05 ishanrai05 marked this pull request as draft August 3, 2020 04:43
@ishanrai05 ishanrai05 marked this pull request as ready for review August 3, 2020 07:41
@ishanrai05 ishanrai05 marked this pull request as draft August 3, 2020 07:42
Copy link
Contributor

@sharad1126 sharad1126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use es-unified-test7.cern.ch for all es connections.

Copy link
Contributor

@sharad1126 sharad1126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use the dataset /TTJets_mtop1695_TuneCUETP8M1_13TeV-amcatnloFXFX-pythia8/RunIIWinter15GS-MCRUN2_71_V1-v1/GEN-SIM as input to the getSubscription test function. please also use this for listRequests

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants