BB2-4194: fix failing integration tests #1397
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BB2-4194
What Does This PR Do?
Fixes integration tests that were failing, and ensures that the Jenkins pipeline reports failure if unit or integration tests fail.
What Should Reviewers Watch For?
If you're reviewing this PR, please check for these things in particular:
That the integration tests now pass locally and in the Jenkins pipeline.
It appears that the pipeline was not reporting failures accurately, as when integration or unit tests failed, that failure was being caught and we were exiting normally, rather than propagating an exit code of 1.
Validation
Run the integration tests locally:
docker-compose/run_integration_tests_local.sh dcand ensure they all pass. Review this Jenkins run to confirm it successfully reported failure.If unit or integration tests fail locally, the sys.exit(1) should not execute.
What Security Implications Does This PR Have?
Please indicate if this PR does any of the following:
security engineer's approval.
Any Migrations?
etc)