Skip to content

Conversation

@JamesDemeryNava
Copy link
Contributor

@JamesDemeryNava JamesDemeryNava commented Oct 17, 2025

JIRA Ticket:
BB2-4194

What Does This PR Do?

Fixes integration tests that were failing, and ensures that the Jenkins pipeline reports failure if unit or integration tests fail.

What Should Reviewers Watch For?

If you're reviewing this PR, please check for these things in particular:

That the integration tests now pass locally and in the Jenkins pipeline.

It appears that the pipeline was not reporting failures accurately, as when integration or unit tests failed, that failure was being caught and we were exiting normally, rather than propagating an exit code of 1.

Validation

Run the integration tests locally: docker-compose/run_integration_tests_local.sh dc and ensure they all pass. Review this Jenkins run to confirm it successfully reported failure.

If unit or integration tests fail locally, the sys.exit(1) should not execute.

What Security Implications Does This PR Have?

Please indicate if this PR does any of the following:

  • Adds any new software dependencies
  • Modifies any security controls
  • Adds new transmission or storage of data
  • Any other changes that could possibly affect security?
  • Yes, one or more of the above security implications apply. This PR must not be merged without the ISSO or team
    security engineer's approval.

Any Migrations?

  • Yes, there are migrations
    • The migrations should be run PRIOR to the code being deployed
    • The migrations should be run AFTER the code is deployed
    • There is a more complicated migration plan (downtime,
      etc)
  • No migrations

@JamesDemeryNava JamesDemeryNava marked this pull request as ready for review October 17, 2025 17:15
@JamesDemeryNava JamesDemeryNava changed the title Jamesdemery/bb2 4194 fix failing integration tests BB2-4194: fix failing integration tests Oct 20, 2025
Copy link
Contributor

@jimmyfagan jimmyfagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on live review, good to merge!

@JamesDemeryNava JamesDemeryNava merged commit a25ab44 into master Oct 20, 2025
8 checks passed
@JamesDemeryNava JamesDemeryNava deleted the jamesdemery/BB2-4194-fix-failing-integration-tests branch October 20, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants