Skip to content

Conversation

stiwarisemanticbits
Copy link
Contributor

JIRA Ticket:
BB2-4174

What Does This PR Do?

This PR fixes selenium tests

What Should Reviewers Watch For?

Execute this locally ./docker-compose/run_selenium_tests_local.sh all tests should pass

If you're reviewing this PR, please check for these things in particular:

Validation

What Security Implications Does This PR Have?

Please indicate if this PR does any of the following:

  • Adds any new software dependencies
  • Modifies any security controls
  • Adds new transmission or storage of data
  • Any other changes that could possibly affect security?
  • Yes, one or more of the above security implications apply. This PR must not be merged without the ISSO or team
    security engineer's approval.

Any Migrations?

  • Yes, there are migrations
    • The migrations should be run PRIOR to the code being deployed
    • The migrations should be run AFTER the code is deployed
    • There is a more complicated migration plan (downtime,
      etc)
  • No migrations

Copy link
Contributor

@JamesDemeryNava JamesDemeryNava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests pass for me in this branch, where three fail in master (test_auth_grant_w_no_demo_v2, test_authorize_lang_english_button, and test_v2_authorization_and_scopes). Would maybe wait for one other approval, but looks good!

@jimmyfagan
Copy link
Contributor

Going to move this to draft until we investigate what is happening in remote cases, just because I don't expect these changes to fix the SLS changes we've seen recently.

@jimmyfagan jimmyfagan marked this pull request as draft October 20, 2025 19:51
# Set bash builtins for safety
set -e -u -o pipefail

export USE_NEW_PERM_SCREEN=false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to capture the note from eng sync, let's also remove the -p option altogether, both in this and the local version in the other file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants