-
Notifications
You must be signed in to change notification settings - Fork 28
BB2-4174: Fixed selenium tests #1399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All tests pass for me in this branch, where three fail in master (test_auth_grant_w_no_demo_v2, test_authorize_lang_english_button, and test_v2_authorization_and_scopes). Would maybe wait for one other approval, but looks good!
3ffbdb9
to
e40f556
Compare
Going to move this to draft until we investigate what is happening in remote cases, just because I don't expect these changes to fix the SLS changes we've seen recently. |
# Set bash builtins for safety | ||
set -e -u -o pipefail | ||
|
||
export USE_NEW_PERM_SCREEN=false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to capture the note from eng sync, let's also remove the -p
option altogether, both in this and the local version in the other file.
JIRA Ticket:
BB2-4174
What Does This PR Do?
This PR fixes selenium tests
What Should Reviewers Watch For?
Execute this locally
./docker-compose/run_selenium_tests_local.sh
all tests should passIf you're reviewing this PR, please check for these things in particular:
Validation
What Security Implications Does This PR Have?
Please indicate if this PR does any of the following:
security engineer's approval.
Any Migrations?
etc)