-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom error with hardhat support #217
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* For loops and function arguments optimization * Substitute require statements with custom errors
…idity version to 0.8.20, update code and test for MetaTxModule, replace _beforeTokenTransfer by _update
2 tasks
…est through Hardhat + update SnapshotModule test to support Hardhat and upgrade to the latest OpenZeppelin version
rya-sge
added
enhancement
New feature or request
Update
Update a library
Proxy
Issue affecting the proxy part
labels
Aug 16, 2023
… and improve error message in the code
…th custom errors and improve error message in the code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This task is made of these following subtasks:
Custom errors inside the solidity code (A)
OpenZeppelin (B)
_beforeTokenTransfer
is replaced by_update
ERC20Upgradeable._update
at the end of the function inside the surcharge of_update
ERC20Upgradeable._update
inside the surcharge ofupdate
_beforeTokenTransfer
is replaced by_update
Update the tests (C)
getTime
=> reduce the time for the test in a significative way.Related to #133
Closes #131, #61
For reference: https://blog.openzeppelin.com/defining-industry-standards-for-custom-error-messages-to-improve-the-web3-developer-experience