Allow 'instructors' group to create categories; seed group in installer; tests and debug additions #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er; tests and debug additions
acee3
approved these changes
Oct 2, 2025
acee3
left a comment
acee3
left a comment
There was a problem hiding this comment.
Looks good but needs some minor changes
|
|
||
| // DEBUG: inspect why certain uids are allowed | ||
| try { | ||
| console.log('[DEBUG privs.filterUids] privilege=%s cid=%s uids=%o allowedTo=%o isAdmins=%o', privilege, cid, uids, allowedTo, isAdmins); |
There was a problem hiding this comment.
The try catch block here might not be necessary
| const isInstructors = await Groups.isMember(id, 'instructors').catch(() => false); | ||
| return { id, username, isAdmin, isRegistered, isInstructors }; | ||
| })); | ||
| console.log('DEBUG: uid info ->', info); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow members of a new instructors group to create categories without giving full admin privileges.
Seed an instructors group during install/setup.
Add a test verifying that members of instructors can create categories.
Note: I added temporary debug logging to investigate a remaining test failure in privileges.categories.filterUids. Most category tests pass locally; one test still needs investigation. I can remove debug logging and fix the test before merging if you prefer.