Implement notifications for follow-up requests and resolutions #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhazard434
requested review from
ChrisTimperley and
lhazard434
and removed request for
lhazard434
aditi-agni
requested changes
Oct 2, 2025
aditi-agni
left a comment
aditi-agni
left a comment
There was a problem hiding this comment.
Since there was just one method that was added, it looked okay on first glance. But due to failing tests I would double check the logic and existing test cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the notification system for the follow-up feature as part of the implementation for GitHub issue #166. The changes include:
Summary of Changes:
Notification Logic:
Added notifications to alert staff when a follow-up is requested.
Added notifications to inform the requester when a follow-up is resolved.
Backend Updates:
Integrated notification creation and dispatch logic into the requestFollowUp and resolveFollowUp methods in topics.js.
Utilized the Notifications.create and Notifications.push methods to handle notification delivery.
Bug Fixes:
Resolved an undefined privileges error by importing the required module.
Testing:
The notification logic has been implemented but requires unit and integration tests to ensure proper functionality across different user roles.
Next Steps:
Write and validate tests for the follow-up feature.
Ensure notifications are displayed correctly in the UI.
This PR completes the notification sub-task for the follow-up feature. Let me know if further adjustments are needed!