this did not work #246
Open
this did not work #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliez07
reviewed
Oct 2, 2025
charliez07
left a comment
charliez07
left a comment
There was a problem hiding this comment.
Adds private field to post/topic creation and filters visibility in privileges.
Lacks description: please explain intended behavior, expected visibility rules, and edge cases.
No tests: need coverage for author, admin, and non-author views.
Clarify handling of old posts without private field (default public?).
Suggest adding short docs/comments and improving readability of privatePosts check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.