Add show/hide password toggle to login form (Issue #257) #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chuksll
approved these changes
Oct 2, 2025
Chuksll
left a comment
Chuksll
left a comment
There was a problem hiding this comment.
Properly fixed qlty smells and properly implemented the feature for a see password toggle button. However, while feature is functionable the UI for it is horrific, it is not easily visible to the user . Moreover, it occupies the same space as the password input which is not the usual. Fixing the coloring of the button to be visible and putting it at the bottom is sufficient. Overall a good PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements Issue #257 by adding a “show/hide password” toggle to the login form. Users can now click an eye icon to reveal their password input, making it easier to confirm accuracy when logging in.
Details
Added an eye icon button next to the password input field.
Password input defaults to hidden (type="password").
Clicking the icon toggles the field between masked and plain text.
Styling follows the project’s existing UI conventions to ensure the feature looks consistent and intuitive.
Why this change matters
Previously, users had no way to verify their password entries, which often led to login errors caused by typos. This feature improves usability and accessibility by letting users double-check their input without compromising security.
Acceptance Criteria
Passwords remain hidden by default.
Toggle button reveals/hides the password text when clicked.
Implementation matches existing UI styling.