Test: Added Jshint (Static Analysis)

[fatbiscuit247]

JSHINT STATIC ANALYSIS TOOL RESULTS

1. installed jshint
2. created .jshintrc file and added settings

3. ran jshint tool on endorse feature related files and all files
4. generated output files showing analysis of the jshint tool

Strengths: Catching simple syntactic code bugs that could have led to hours of debugging

Weakness: Doesn't check for correctness, complexity, or memory leaks.

- What types of problems are you hoping your tooling will catch? What types of problems does this particular tool catch?
JSHINT catches suspicious usage within the javascript files. I'm hoping the tool will catch:

1. unused variables
2. redundant variables
3. bugs

What it actually catches:

1. unused variables
2. redundant variables
3. bugs
4. using == instead of ===
5. consistency of syntax

- What types of customization are possible or necessary?

Through the .jshintrc configuration file, it is possible to customize/disable some rules. For example, I would definitely disable the redundant variables warning, since this is a majority of the errors and it seems to be pointing out the use strict directive or util that is defined the same way throughout each file, but not something I should change.

- How can/should this tool be integrated into a development process?
Catching possible common bugs, syntax errors, and unnecessary/unused variables in a large codebase that could have led to hours of debugging.

- Are there many false positives? False negatives? True positive reports about things you don’t care about?

• False positives : yes -> since jshint only checks statically, it raises flags to a lot of syntactic things such as redefinitions of variables, or confusing uses of !, but these are not necessarily logically incorrect and doesn't affect the code. (defining the same variable util, or the use strict directive the same way across different files that you don't necessarily want to get rid of)
• False Negative: possible -> since jshint only checks statically and does not run the code, there are certain edge cases that syntactically are fine, but raise an error. For example running a/b is syntactically fine but doesn't catch the divide by zero case.
• True positive: yes -> if you forget a semicolon, or simple coding bugs it will correctly detect these errors.

[coveralls]

Pull Request Test Coverage Report for Build 18702971276

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 78.447%

---

Totals
Change from base Build 18662777222:	0.0%
Covered Lines:	24893
Relevant Lines:	29874

---

💛 - Coveralls