Skip to content
This repository was archived by the owner on Feb 9, 2026. It is now read-only.
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ dependencies {
testImplementation "org.junit.jupiter:junit-jupiter:5.7.2"
testImplementation "org.assertj:assertj-core:3.19.0"
}

test {
useJUnitPlatform()
}
8 changes: 8 additions & 0 deletions src/main/java/Application.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
import gameController.GameController;

public class Application {
public static void main(String[] args) {
GameController gameController = new GameController();
gameController.start();
}
}
25 changes: 25 additions & 0 deletions src/main/java/domain/generator/BaseBallNumbersGenerator.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
package domain.generator;

import domain.model.BaseBallNumbers;

import java.util.ArrayList;
import java.util.List;

public class BaseBallNumbersGenerator {
private final NumberGenerator numberGenerator;

public BaseBallNumbersGenerator(NumberGenerator numberGenerator) {
this.numberGenerator = numberGenerator;
}

public List<Integer> generate() {
List<Integer> numbers = new ArrayList<>();
while (numbers.size() < BaseBallNumbers.NumberSize) {
int num = numberGenerator.generate();
if (!numbers.contains(num)) {
numbers.add(num);
}
}
return numbers;
}
}
5 changes: 5 additions & 0 deletions src/main/java/domain/generator/NumberGenerator.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
package domain.generator;

public interface NumberGenerator {
int generate();
}
12 changes: 12 additions & 0 deletions src/main/java/domain/generator/RandomNumbersGenerator.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
package domain.generator;

import java.util.Random;

public class RandomNumbersGenerator implements NumberGenerator {
private final Random random = new Random();

@Override
public int generate() {
return random.nextInt(9) + 1;
}
}
55 changes: 55 additions & 0 deletions src/main/java/domain/model/BaseBallNumbers.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
package domain.model;

import java.util.ArrayList;
import java.util.List;

public class BaseBallNumbers {
public static final int NumberSize = 3;
private final List<Integer> numbers;
public static BaseBallNumbers from(List<Integer> numbers) {
return new BaseBallNumbers(numbers);
}
public static BaseBallNumbers parse(String input) {
List<Integer> numbers = new ArrayList<>();
for (char c : input.toCharArray()) {
numbers.add(Character.getNumericValue(c));
}
return new BaseBallNumbers(numbers);
}

private BaseBallNumbers(List<Integer> numbers) {
validate(numbers);
this.numbers = numbers;
}

private void validate(List<Integer> numbers) {
if (numbers.size() != NumberSize) {
throw new IllegalArgumentException("숫자는 " + NumberSize + "개여야 합니다.");
}
if (numbers.stream().distinct().count() != NumberSize) {
throw new IllegalArgumentException("중복된 숫자가 있습니다.");
}
for (int num : numbers) {
if (num < 1 || num > 9) {
throw new IllegalArgumentException("숫자는 1-9 사이여야 합니다.");
}
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

숫자가 3이여야 한다는 것은 정책 아닌가? 이 숫자가 여러 번 등장하는데, 정책이 바뀔 때 마다 여러 번 등장하는 해당 숫자가 변경되어야 한다.

상수로 처리하거나, 로직을 변경하는 게 좋을 듯 하다

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

테스트 가능한 코드를 위해 NumberGenerator 인터페이스 추가
이렇게 인터페이스를 추상화해야 테스트에서 임의의 값을 생성할 수 있음
=> 그러나 추상화에 대한 이해가 잘 안됨 좀더 고민이 필요한듯..
=> 왜 interface로 선언해야하지? 최소한의 동일성을 위해?
현재 프로젝트가 너무 단순해서 필요성을 못 느껴서 그럴 수 있겠단 생각
요구사항이 많아질수록 인터페이스를 쓰는게 테스트하기 더 좋아지지 않을까
(테스트를 위해 전부 다시 선언하는건 너무 소모적이라?)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SongHanSol1140
인터페이스의 장점을 잘 생각하면 좋을 듯 하다. 이 경우 아래와 같이 사용했다. (네가, 일부는.)

  • 운영 환경 : RandomNumberGenerator
  • 테스트 환경 : FixedNumberGenerator -> 이 구현체는 항상 '5'를 반환한다.

이 경우 테스트 환경에만 존재하는 FixedNumberGenerator 를 Stub 이라고 하며, 인터페이스의 반환값이나 입력값이 변경되지 않는 한 해당 구현체도 변경 될 필요가 없다.

현재 구현에서는 "랜덤 넘버를 만든다" 자체를 테스트 하기가 어렵기 때문에 위와 같이 작성해야 했는데, 이 외에도 여러 장점이 있다.

  • V1, V2 ... 버전이 몇 개 생기더라도, 이전 버전 클래스를 삭제하지 않고 사용하다가 이후 버전으로 마이그레이션 가능하다. (e.g @deprecated)
  • 하나의 인터페이스에 여러 구현체가 존재하며, 구현체 타입별로의 분기가 가능하다. (e.g PG사)
    • 네이버페이.pay
    • 카카오페이.pay
    • ...


public int get(int index) {
return numbers.get(index);
}

public boolean contains(int num) {
return numbers.contains(num);
}

public int size() {
return numbers.size();
}
// 값 확인용
@Override
public String toString() {
return numbers.toString();
}
}
27 changes: 27 additions & 0 deletions src/main/java/domain/model/GameResult.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
package domain.model;

public class GameResult {
private final int strike;
private final int ball;

public GameResult(int strike, int ball) {
this.strike = strike;
this.ball = ball;
}

public boolean isWin() {
return strike == BaseBallNumbers.NumberSize;
}

public boolean isNothing() {
return strike == 0 && ball == 0;
}

public int getStrike() {
return strike;
}

public int getBall() {
return ball;
}
}
22 changes: 22 additions & 0 deletions src/main/java/domain/service/Referee.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
package domain.service;

import domain.model.BaseBallNumbers;
import domain.model.GameResult;

public class Referee {

public GameResult decides(BaseBallNumbers problemNumbers, BaseBallNumbers inputNumber) {
int strike = 0;
int ball = 0;

for (int i = 0; i < problemNumbers.size(); i++) {
int guessNum = inputNumber.get(i);
if (guessNum == problemNumbers.get(i)) {
strike++;
} else if (problemNumbers.contains(guessNum)) {
ball++;
}
}
return new GameResult(strike, ball);
}
}
46 changes: 46 additions & 0 deletions src/main/java/gameController/GameController.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
package gameController;

import domain.model.BaseBallNumbers;
import domain.model.GameResult;
import domain.service.Referee;
import domain.generator.BaseBallNumbersGenerator;
import domain.generator.RandomNumbersGenerator;
import handler.InputHandler;
import view.OutputView;


public class GameController {
private final InputHandler inputHandler;
private final OutputView outputView;
private final Referee referee;
private int failCount;

public GameController() {
this.inputHandler = new InputHandler();
this.outputView = new OutputView();
this.referee = new Referee();
this.failCount = 0;
}

public void start() {
BaseBallNumbersGenerator numberGenerator = new BaseBallNumbersGenerator(new RandomNumbersGenerator());
BaseBallNumbers problemNumbers = BaseBallNumbers.from(numberGenerator.generate());
outputView.printGameStart();
try {
while (true) {
String userInput = inputHandler.getUserInput();
BaseBallNumbers userNumbers = BaseBallNumbers.parse(userInput);
GameResult gameResult = referee.decides(problemNumbers, userNumbers);
if (gameResult.isWin()) {
outputView.printWin();
break;
}
failCount++;
outputView.printResult(gameResult.getStrike(), gameResult.getBall(), failCount);
}
inputHandler.close();
} catch (IllegalArgumentException error) {
System.out.println(error.getMessage());
}
}
}
43 changes: 43 additions & 0 deletions src/main/java/handler/InputHandler.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
package handler;

import domain.model.BaseBallNumbers;

import java.util.Scanner;

public class InputHandler {
private final Scanner scanner;
public InputHandler() {
this.scanner = new Scanner(System.in);
}

public String getUserInput() {
System.out.print("숫자를 입력하세요: ");
String input = scanner.nextLine();
validate(input);
return input;
}

private void validate(String input) {
// 자릿수 체크
if (input.length() != BaseBallNumbers.NumberSize) {
throw new IllegalArgumentException("3자리 숫자를 입력하세요.");
}
Comment on lines 21 to 24
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기도 3이라는 매직넘버가 등장한다.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

모델 BaseBallNumbers에 게임에 사용될 숫자 갯수 상수로 수정

// 1-9 숫자 확인
for (int i = 0; i < BaseBallNumbers.NumberSize; i++) {
char c = input.charAt(i);
if (c < '1' || c > '9') {
throw new IllegalArgumentException("1-9 사이 숫자만 입력하세요.");
}
}
// 중복 체크
if (input.chars().distinct().count() != BaseBallNumbers.NumberSize) {
throw new IllegalArgumentException("중복된 숫자는 입력할 수 없습니다.");
}

}

// 재시작 로직이
public void close() {
scanner.close();
}
}
28 changes: 28 additions & 0 deletions src/main/java/view/OutputView.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
package view;

public class OutputView {

public void printGameStart() {
System.out.println("숫자 야구 게임 시작");
}

public void printResult(int strike, int ball, int failCount) {
StringBuilder text = new StringBuilder();
if (strike > 0) {
text.append(strike).append("스트라이크 ");
}
if (ball > 0) {
text.append(ball).append("볼 ");
}
if (strike == 0 && ball == 0) {
text.append("일치값 없음 ");
}

text.append("(").append(failCount).append("번 실패)");
System.out.println(text.toString());
}

public void printWin() {
System.out.println("정답!");
}
}
39 changes: 39 additions & 0 deletions src/test/java/domain/generator/BaseBallNumbersGeneratorTest.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
package domain.generator;

import org.junit.jupiter.api.Test;

import java.util.List;

import static org.assertj.core.api.Assertions.assertThat;

public class BaseBallNumbersGeneratorTest {

@Test
void Numbers123Test() {
NumberGenerator fixedGenerator = new TestNumberGenerator(1, 2, 3);
BaseBallNumbersGenerator generator = new BaseBallNumbersGenerator(fixedGenerator);
List<Integer> result = generator.generate();
assertThat(result).containsExactly(1, 2, 3);
// assertThat(result) => 검사할 값
// containsExactly > 배열이 일치하는지 확인(가변 배열을 인자로 받음)
System.out.println("Number123Test Check Complete");
}

@Test
void Numbers459() {
NumberGenerator fixedGenerator = new TestNumberGenerator(4, 5, 9);
BaseBallNumbersGenerator generator = new BaseBallNumbersGenerator(fixedGenerator);
List<Integer> result = generator.generate();
assertThat(result).containsExactly(4, 5, 9);
System.out.println("Numbers459 Check Complete");
}

@Test
void duplicateNumbersCheck() {
NumberGenerator fixedGenerator = new TestNumberGenerator(1, 1, 2, 3);
BaseBallNumbersGenerator generator = new BaseBallNumbersGenerator(fixedGenerator);
List<Integer> result = generator.generate();
assertThat(result).containsExactly(1, 2, 3);
assertThat(result).hasSize(3);
}
}
15 changes: 15 additions & 0 deletions src/test/java/domain/generator/TestNumberGenerator.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
package domain.generator;

public class TestNumberGenerator implements NumberGenerator {
private final int[] numbers;
private int index = 0;

public TestNumberGenerator(int... numbers) {
this.numbers = numbers;
}

@Override
public int generate() {
return numbers[index++];
}
}