Open
Conversation
ca1af
reviewed
Nov 12, 2023
Comment on lines
+12
to
+13
| Car(String carName){ | ||
| if(carName.length()>5)throw new IllegalArgumentException("차 이름은 5자를 초과할 수 없습니다."); |
Collaborator
There was a problem hiding this comment.
접근제어자를 사용하지 않은 이유가 있을까요?
Validation 로직은 매서드로 따로 빼면 어떨까요?
Comment on lines
+32
to
+34
| private void addScore(){ | ||
| this.score = getScore()+1; | ||
| } |
Comment on lines
+36
to
+40
| public void drive(){ | ||
| double r = Math.random(); | ||
| int t = Math.toIntExact(Math.round(r * 10)); | ||
| if(t>=4) addScore(); | ||
| } |
Comment on lines
+42
to
+44
| public boolean isWin(){ | ||
| return win; | ||
| } |
Comment on lines
+6
to
+8
| private static final CarNameView carNameView = new CarNameView(); | ||
| private static final RaceTryView raceTryView = new RaceTryView(); | ||
| private static final RaceResultView raceResultView = new RaceResultView(carNameView, raceTryView); |
Collaborator
There was a problem hiding this comment.
final 을 쓰는 이유가 뭘까요? (++static?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.