feat(EM-31): Extract ftgo-common-jpa and ftgo-domain as Versioned Shared Libraries#38
Open
devin-ai-integration[bot] wants to merge 1 commit intofeat/microservices-migrationfrom
Conversation
…red libraries - Extract ftgo-common-jpa under libs/ftgo-common-jpa/ with JPA config, Money embeddable, orm.xml, and Spring Boot auto-configuration - Extract ftgo-domain under libs/ftgo-domain/ with all domain entities, repositories, value objects, and DomainConfiguration - Create API/DTO modules under apis/ for cross-service communication (order, consumer, restaurant, courier service APIs) - All libraries versioned at 1.0.0 with maven-publish support - Update settings.gradle with new :libs: and :apis: module includes - Update entity-to-service ownership documentation - Original ftgo-common-jpa/ and ftgo-domain/ directories preserved Co-Authored-By: mason.batchelor@cognition.ai <masonbatchelor81@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(EM-31): Extract ftgo-common-jpa and ftgo-domain as Versioned Shared Libraries
Summary
Populates the
libs/ftgo-common-jpa/andlibs/ftgo-domain/placeholder directories as versioned, publishable shared libraries withjava-library+maven-publishGradle configurations. Also populates the fourapis/placeholder directories with build configs and DTO source files for cross-service communication contracts.Key changes:
libs/ftgo-common-jpa/—FtgoJpaConfiguration,Moneyembeddable,orm.xml, Spring Boot auto-config,maven-publishat version1.0.0libs/ftgo-domain/— All 22 domain entity/repository/value-object Java files, depends on:ftgo-commonand:libs:ftgo-common-jpa,maven-publishat version1.0.0apis/{order,consumer,restaurant,courier}-service-api/— Each gets abuild.gradlewithjava-library+maven-publishand DTO source files copied from the flat API modulessettings.gradle— Adds:libs:ftgo-common-jpa,:libs:ftgo-domain, and four:apis:*module includesdocs/entity-ownership.md— Expanded with Gradle paths, versions, API/DTO module table, and migration notesOriginal
ftgo-common-jpa/andftgo-domain/directories are not deleted.Review & Testing Checklist for Human
ftgo-domain/,libs/ftgo-domain/, andlibs/ftgo-domain-lib/(same for common-jpa). Verify this triple-copy approach aligns with the migration plan and that there's no expectation to wire originals as delegates instead.compileJavawas verified in this session. Run./gradlew test -x :ftgo-end-to-end-tests-common:test -x :ftgo-end-to-end-tests:test -x :ftgo-application:testto ensure no runtime issues.:ftgo-common-jpa(flat) and:libs:ftgo-common-jpa(nested) are included insettings.gradle. Same for domain and API modules. Confirm this doesn't cause confusion for downstream consumers.sourceCompatibility = '8'for backward compatibility. Verify this is correct vs the Java 17 target inbuildSrc-platformconvention plugins.:libs:*or:apis:*paths — existing services still depend on flat modules. Verify the migration plan for when/how to switch consumers over.Test Plan
./gradlew compileJava(already verified ✅)./gradlew test -x :ftgo-end-to-end-tests-common:test -x :ftgo-end-to-end-tests:test -x :ftgo-application:test./gradlew :libs:ftgo-common-jpa:publish :libs:ftgo-domain:publishsucceeds and artifacts appear inbuild/repo/docs/entity-ownership.mdis accurateNotes
-libvariants (ftgo-common-jpa-lib,ftgo-domain-lib) are marked as deprecated in docs but not removed — they remain for backward compatibility during migrationlibs/ftgo-domain/src/main/java/net/chrisrichardson/ftgo/domain/OrderLineItems.java(minor)