chore(js-ts): Convert TabBar.js to TypeScript#308
Open
devin-ai-integration[bot] wants to merge 2 commits intomainfrom
Open
chore(js-ts): Convert TabBar.js to TypeScript#308devin-ai-integration[bot] wants to merge 2 commits intomainfrom
devin-ai-integration[bot] wants to merge 2 commits intomainfrom
Conversation
- Convert app/components/Base/TabBar.js to TabBar.tsx - Add proper TypeScript interfaces for styles - Use Theme['colors'] type from @metamask/design-tokens - Use TabBarProps<DefaultTabBarProps> from react-native-scrollable-tab-view - Follow established patterns from other migrated components Co-Authored-By: benc@cognition.ai <Benc@windsurf.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
…ab-view - Remove explicit ViewStyle/TextStyle imports to avoid type conflicts - Use index signature interface for props to allow pass-through - Import DefaultTabBar directly from submodule path - Let TypeScript infer style types from StyleSheet.create Co-Authored-By: benc@cognition.ai <Benc@windsurf.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Converts
app/components/Base/TabBar.jsto TypeScript following the established migration patterns in the codebase.Changes:
TabBar.js→TabBar.tsxcreateStylesfunction withTheme['colors']parameter from@metamask/design-tokensTabBarPropsinterface with index signature for flexible prop passing toDefaultTabBarStyleSheet.create(avoids type conflicts with multiple@types/react-nativeversions in node_modules)Review & Testing Checklist for Human
Test Plan
TabBar(e.g., wallet tabs, notification tabs)Notes
yarn lint:tsc) verified locally - passes successfullyapp/components/UI/Notification/List/index.tsxwhich also usesDefaultTabBarlint:tsccheck was cancelled due to unrelatedaudit:cifailure (pre-existing dependency vulnerabilities), but all unit tests passLink to Devin run: https://app.devin.ai/sessions/d658aedd9ce948b9b0b4057e04304fa6
Requested by: @bcmake