Skip to content

Comments

chore: migrate app/util/test/ganache.js to TypeScript#310

Open
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin/1770405398-migrate-ganache-to-ts
Open

chore: migrate app/util/test/ganache.js to TypeScript#310
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin/1770405398-migrate-ganache-to-ts

Conversation

@devin-ai-integration
Copy link

@devin-ai-integration devin-ai-integration bot commented Feb 6, 2026

Summary

Migrates app/util/test/ganache.js from JavaScript to TypeScript by:

  • Adding proper type imports from the ganache package (Server, ServerOptions, EthereumProvider)
  • Creating a GanacheOptions interface for the start method options
  • Adding explicit type annotations to all class methods and properties
  • Replacing non-null assertions with explicit null checks to satisfy ESLint rules

Review & Testing Checklist for Human

  • Verify the GanacheOptions interface correctly extends ServerOptions without type conflicts
  • Run any e2e tests that use the Ganache class to ensure the migration doesn't break test functionality
  • Confirm the balanceHex as string type assertion on line 68 is safe for all ganache provider responses

Notes

  • The pre-existing typecheck errors in the codebase (related to PreferencesController) are unrelated to this change
  • The @typescript-eslint/no-parameter-properties lint error appears on all TS files in the repo and is a configuration issue, not specific to this file

Link to Devin run: https://app.devin.ai/sessions/72022e25d28341ecb8aa0efa27d554eb
Requested by: @shayanshafii


Open with Devin

Co-Authored-By: shayan@cognition.ai <shayan@cognition.ai>
@devin-ai-integration
Copy link
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Copy link
Author

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants