chore: migrate app/util/test/ganache.js to TypeScript#310
Open
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Open
chore: migrate app/util/test/ganache.js to TypeScript#310devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
Co-Authored-By: shayan@cognition.ai <shayan@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates
app/util/test/ganache.jsfrom JavaScript to TypeScript by:ganachepackage (Server,ServerOptions,EthereumProvider)GanacheOptionsinterface for the start method optionsReview & Testing Checklist for Human
GanacheOptionsinterface correctly extendsServerOptionswithout type conflictsbalanceHex as stringtype assertion on line 68 is safe for all ganache provider responsesNotes
PreferencesController) are unrelated to this change@typescript-eslint/no-parameter-propertieslint error appears on all TS files in the repo and is a configuration issue, not specific to this fileLink to Devin run: https://app.devin.ai/sessions/72022e25d28341ecb8aa0efa27d554eb
Requested by: @shayanshafii