chore(js-ts): migrate AppInformation component to TypeScript#313
Open
devin-ai-integration[bot] wants to merge 2 commits intomainfrom
Open
chore(js-ts): migrate AppInformation component to TypeScript#313devin-ai-integration[bot] wants to merge 2 commits intomainfrom
devin-ai-integration[bot] wants to merge 2 commits intomainfrom
Conversation
Co-Authored-By: Joao Esteves <joao.esteves@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: Joao Esteves <joao.esteves@cognition.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chore(js-ts): migrate AppInformation component to TypeScript
Summary
Migrates
app/components/Views/Settings/AppInformation/index.jsfrom JavaScript to TypeScript (.tsx), as part of the ongoing JS→TS migration effort.Key changes:
PropTypeswith TypeScript interfaces (AppInformationProps,AppInformationState)navigationprop asNavigationProp<ParamListBase>(matching project convention)declare context: Themefor ThemeContext typingcreateStylesparameter asColors, andgoToparameters asstringrequire()image import to ES moduleimportstyles.links— this key never existed in the stylesheet, so it was alwaysundefinedat runtime. The<View>elements now simply have no style prop, which is functionally identical.@ts-expect-errorin the test file to work aroundrenderScreenacceptingReact.ComponentType<{}>, which conflicts with the now-typed requirednavigationprop (navigation is injected at runtime byStack.Screen).Review & Testing Checklist for Human
styles.linksremoval is safe: Confirm that the stylesheet truly never defined alinkskey and that no other mechanism injected this style. The original code had<View style={styles.links}>in two places, butcreateStylesonly defineslink(singular). Removal should be a no-op, but worth confirming.style={styles.links}(which wasundefined) from two<View>elements may or may not change the rendered snapshot. Runyarn jest app/components/Views/Settings/AppInformation/index.test.tsx --updateSnapshotif the snapshot needs regenerating, and verify the diff is trivial.declare context: Theme: TheThemeContextis created asReact.createContext<any>(undefined), so context could technically beundefined. The code handles this withthis.context.colors || mockTheme.colors, but the declared type doesn't reflect theundefinedcase. Verify this is acceptable given the existing pattern.Notes