chore(js-ts): Convert app/reducers/alert to TypeScript#314
Open
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Open
chore(js-ts): Convert app/reducers/alert to TypeScript#314devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
Co-Authored-By: Shannon Hittson <shannon.hittson@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chore(js-ts): Convert app/reducers/alert to TypeScript
Summary
Converts the
alertRedux reducer from JavaScript to TypeScript as part of the incremental TS migration. Replaces theanytype foralertin theRootStateinterface with a properAlertStatetype.Changes:
app/reducers/alert/index.js→index.ts: Adds typed state, action enum (AlertActionType), and action types (ShowAlertAction,HideAlertAction). ExportsinitialAlertState.app/reducers/alert/types.ts(new): Defines theAlertStateinterface.app/reducers/index.ts: ImportsAlertStateand replaces theanytype + TODO comment for thealertfield inRootState.app/util/test/initial-root-state.ts: UsesinitialAlertStateinstead ofundefinedto satisfy the new type.Review & Testing Checklist for Human
datatype is not too narrow:datais typed as{ msg: string } | null. Confirm all existing callers ofshowAlert()across the codebase always passdatawith only amsg: stringfield (grep forshowAlert(to spot-check). If any caller passes additional or different properties, this type will silently discard them at the type level.app/actions/alert/index.jswas not converted in this PR — it still uses raw'SHOW_ALERT'/'HIDE_ALERT'string literals. Verify this is acceptable for an incremental migration, or if it should be included.yarn lint:tsc(passes locally). Runyarn test:uniton any alert-related tests if they exist. Verify the app still shows/hides alert banners (e.g., "address copied to clipboard" toast) after the change.Notes
UserState,SecurityState, etc.)