refactor: migrate app/util/test/ganache.js to TypeScript#321
Open
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Open
refactor: migrate app/util/test/ganache.js to TypeScript#321devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
Co-Authored-By: shayan@cognition.ai <shayan@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor: migrate app/util/test/ganache.js to TypeScript
Summary
Migrates
app/util/test/ganache.jsto TypeScript (ganache.ts). Key changes:GanacheStartOptionsinterface (extendingPartial<ServerOptions>) withmnemonicas a required field_serverasprivate _server: Server | undefinedgetProvider()ingetAccounts()andgetBalance()(previously these would throw unclear "cannot read property of undefined" errors)as string[],as string) onprovider.request()return valuesNo import path changes were needed — all consumers use extensionless paths (e.g.
../../app/util/test/ganache) that resolve to.tsautomatically.Review & Testing Checklist for Human
Server,ServerOptions, andEthereumProviderare valid exports from theganachepackage (they appear inganache/dist/ganache.d.tsbut confirm they resolve at build time)GanacheStartOptionsinterface doesn't conflict with properties already inServerOptions— several fields (port,blockTime, etc.) are redeclaredgetAccounts()/getBalance()don't break any existing e2e test flows that might rely on the previous error behaviore2e/fixtures/utils.js,e2e/fixtures/fixture-helper.js,wdio/utils/ganache.js) still resolve the import correctly after the renameNotes