Security Audit: Comprehensive Snyk-equivalent security scan report#327
Open
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Open
Security Audit: Comprehensive Snyk-equivalent security scan report#327devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
Co-Authored-By: Priya Padmanabhan <priya.padmanabhan@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
SECURITY_AUDIT_REPORT.mdcontaining findings from an automated security audit of the MetaMask Mobile repository. The audit was intended to use Snyk MCP but fell back to open-source equivalents (Semgrep, Trivy, Checkov) because the Snyk MCP server was unavailable and the provided Snyk CLI token was a non-functional placeholder.No code changes are included — this PR is report-only. It documents 145 total findings across five scan categories:
SanitizationMiddleware.tsyarn.lockand severalGemfile.lockfilespermissionsdeclarations)package-lock.json; repo usesyarn.lock)The report includes a prioritized 32-item remediation plan.
Review & Testing Checklist for Human
Gemfile.lockfiles inios/branch-ios-sdk/andnode_modules/lottie-*/— these are transitive deps in vendored/third-party code and may not be directly exploitable in the mobile app. The severity counts could be inflated by false positives.app/core/SanitizationMiddleware.ts:103(remote property injection). This is in a sanitization middleware, so it may already be intentionally handling bracket notation safely — or it may be a genuine vulnerability. Semgrep cannot determine context here.Notes
Link to Devin run: https://app.devin.ai/sessions/c4c61ecd43b34b21a779b47d77e46265
Requested by: @priya-cognition