forked from gothinkster/spring-boot-realworld-example-app
-
Notifications
You must be signed in to change notification settings - Fork 11
Upgrade Java 11→21 and Spring Boot 2.6.3→3.2.0 #356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
devin-ai-integration
wants to merge
3
commits into
master
Choose a base branch
from
devin/1771366318-upgrade-java21-springboot3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+19
−19
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
528bc0f
Upgrade Java 11->21 and Spring Boot 2.6.3->3.2.0 with updated depende…
devin-ai-integration[bot] b331e4c
Update CI workflow to use JDK 21
devin-ai-integration[bot] 658340f
Upgrade Gradle wrapper from 7.4 to 8.5 for Java 21 support
devin-ai-integration[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-7.4-bin.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.5-bin.zip | ||
| zipStoreBase=GRADLE_USER_HOME | ||
| zipStorePath=wrapper/dists |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 DGS codegen plugin 5.0.6 is incompatible with DGS runtime 8.1.1
The DGS runtime was bumped from 4.9.21 to 8.1.1, but the
com.netflix.dgs.codegenplugin was left at version 5.0.6. DGS codegen 5.x generates code targeting the DGS 4.x/5.x API surface, while DGS 8.x has a significantly different API (including the move to Jakarta EE namespaces and updated DGS annotations/types).Root Cause and Impact
At
build.gradle:5, the codegen plugin remains at5.0.6, while atbuild.gradle:39the runtime was updated to8.1.1. The DGS codegen plugin generates Java source files (intobuild/generated) that import and use DGS framework classes. When the codegen plugin version doesn't match the runtime version, the generated code references classes/methods that don't exist in the runtime, causing compilation failures.For example, codegen 5.x may generate code importing from
com.netflix.graphql.dgspackages with class signatures matching DGS 4.x/5.x, but DGS 8.x has restructured these packages. The codegen plugin needs to be updated to version 6.x+ (e.g.,6.1.0or later) to generate code compatible with DGS 8.1.1.This is a separate issue from the
javax.*→jakarta.*migration mentioned in the PR description — even after that migration, the generated DGS code will fail to compile due to this version mismatch.Prompt for agents
Was this helpful? React with 👍 or 👎 to provide feedback.