chore: Migrate Java 11 to 17#368
Open
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Open
Conversation
- Update sourceCompatibility/targetCompatibility to Java 17 - Upgrade Spring Boot 2.6.3 -> 2.7.18 - Upgrade Gradle wrapper 7.4 -> 7.6 - Migrate Joda Time -> java.time (Instant) across all source and test files - Remove joda-time dependency - Migrate WebSecurityConfigurerAdapter to SecurityFilterChain (component-based) - Update CI workflow to JDK 17 with actions v4 - Bump mybatis-spring-boot-starter 2.2.2 -> 2.3.2 - Bump jjwt 0.11.2 -> 0.11.5 - Bump sqlite-jdbc 3.36.0.3 -> 3.42.0.1 - Update dependency-management plugin 1.0.11 -> 1.0.15 Co-Authored-By: Joao Esteves <joao.esteves@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chore: Migrate Java 11 to 17 with Joda Time removal
Summary
Modernizes the project from Java 11 to Java 17. The main changes are:
sourceCompatibility/targetCompatibilityset to 17, CI updated to JDK 17java.time.Instant: Allorg.joda.time.DateTimeusages replaced withjava.time.Instant;joda-timedependency removed entirelyWebSecurityConfigurerAdapterremoval: Migrated to component-basedSecurityFilterChainbean (deprecated in Spring Security 5.7+)actions/checkout@v4,actions/setup-java@v4,actions/cache@v4All 68 existing tests pass locally.
Review & Testing Checklist for Human
yyyy-MM-dd'T'HH:mm:ss.SSS'Z'). The format pattern is duplicated inArticleDatafetcher.java:375,382andCommentDatafetcher.java:119,120— check that timestamps in GraphQL responses match the REST API format fromJacksonCustomizations.java:19.WebSecurityConfigurerAdapter→SecurityFilterChainmigration. Test login, JWT token validation, and protected endpoints (/articles/feed,/user, etc.).DateTimeHandler(MyBatis type handler) correctly reads/writes timestamps to SQLite. Check that article/commentcreatedAt/updatedAtfields are persisted and retrieved correctly.Test Plan
createdAt/updatedAttimestamps in the responseNotes
rest-assuredtest library was kept at 4.5.1 (upgrading to 5.3.2 causedNoSuchMethodErrorin tests)WebSecurityConfig.javaduring the refactorInstant.now().minusSeconds(3600)replacesnew DateTime().minusHours(1)in tests (functionally equivalent)Link to Devin run: https://app.devin.ai/sessions/80d1cbc7bfa64750b48c2c29fc6652ea
Requested by: @joao-cognition