Add comprehensive unit tests for core and application layers#372
Open
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Open
Add comprehensive unit tests for core and application layers#372devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Conversation
Add 12 new test files and extend existing ArticleTest with tests for: - Core: User, Comment, Tag, FollowRelation, ArticleFavorite, AuthorizationService - Application: Util, Page, CursorPageParameter, CursorPager, DateTimeCursor - Service: ArticleCommandService (with mocked repository) Tests cover constructors, equality, edge cases, and error conditions. Co-Authored-By: unknown <>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add unit tests for core domain and application layer classes
Summary
Adds 12 new unit test files and extends the existing
ArticleTestto improve test coverage across previously untested core domain and application layer classes. All tests are pure unit tests (no Spring context required), with Mockito used only forArticleCommandService.New test files:
UserTest,CommentTest,TagTest,FollowRelationTest,ArticleFavoriteTest,AuthorizationServiceTestUtilTest,PageTest,CursorPageParameterTest,CursorPagerTest,DateTimeCursorTest,ArticleCommandServiceTestExtended:
ArticleTest— added tests forupdate(), tag deduplication, empty tags, equality, and the two-arg constructor with explicitcreatedAt.Modified (formatting only):
DefaultJwtServiceTest— spotless auto-formatted a long line.Total test count went from ~100 to 146, all passing.
Review & Testing Checklist for Human
ArticleCommandServiceTest: The service is@Validatedin production, but these unit tests instantiate it directly with a mocked repo, so@NotBlank/@DuplicatedArticleConstraintvalidation is not exercised. Verify this is acceptable for unit-level coverage (integration tests elsewhere should cover validation).CursorPagerTestcursor assertions: Start/end cursor assertions compare via.toString()becauseDateTimeCursorlacksequals(). Confirm this is a reasonable approach vs. comparing millis directly../gradlew testlocally to confirm all 146 tests pass and no flaky timing issues (some tests usenew DateTime()which could theoretically cause issues around test boundaries).Notes
DefaultJwtServiceTest.javadiff is a formatting-only change from spotless; no production code was modified.