feat: 로그인 api 연결 serverAction으로 by dasosann · Pull Request #29 · COMAtching/COMAtching5_FE

dasosann · 2026-02-20T08:40:33Z

PR Type

Enhancement

Description

모의 로그인 로직을 실제 백엔드 API 연결로 교체
serverApi를 통한 타입 안전한 API 호출 구현
에러 처리 로직 추가 및 응답 메시지 개선

Diagram Walkthrough

flowchart LR
  A["Mock 로그인 로직"] -- "교체" --> B["serverApi 호출"]
  B -- "POST /api/auth/login" --> C["백엔드 API"]
  C -- "LoginResponse" --> D["성공/실패 처리"]

File Walkthrough

Relevant files

Enhancement

loginAction.ts `Mock 로직을 실제 API 호출로 전환` lib/actions/loginAction.ts 모의 지연 및 하드코딩된 로그인 로직 제거 `serverApi.post()`를 통한 실제 백엔드 API 호출 추가 `LoginResponse` 타입 정의로 응답 구조 명시 try-catch로 에러 처리 및 사용자 친화적 메시지 반환	+16/-14

✨ Describe tool usage guide:

Overview:
The describe tool scans the PR code changes, and generates a description for the PR - title, type, summary, walkthrough and labels. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.

When commenting, to edit configurations related to the describe tool (pr_description section), use the following template:

/describe --pr_description.some_config1=... --pr_description.some_config2=...

With a configuration file, use the following template:

[pr_description]
some_config1=...
some_config2=...

Enabling\disabling automation When you first install the app, the default mode for the describe tool is: `pr_commands = ["/describe", ...]` meaning the `describe` tool will run automatically on every PR. Markers are an alternative way to control the generated description, to give maximal control to the user. If you set: `pr_commands = ["/describe --pr_description.use_description_markers=true", ...]` the tool will replace every marker of the form `pr_agent:marker_name` in the PR description with the relevant content, where `marker_name` is one of the following: `type`: the PR type. `summary`: the PR summary. `walkthrough`: the PR walkthrough. `diagram`: the PR sequence diagram (if enabled). Note that when markers are enabled, if the original PR description does not contain any markers, the tool will not alter the description at all.
Custom labels The default labels of the `describe` tool are quite generic: [`Bug fix`, `Tests`, `Enhancement`, `Documentation`, `Other`]. If you specify custom labels in the repo's labels page or via configuration file, you can get tailored labels for your use cases. Examples for custom labels: `Main topic:performance` - pr_agent:The main topic of this PR is performance `New endpoint` - pr_agent:A new endpoint was added in this PR `SQL query` - pr_agent:A new SQL query was added in this PR `Dockerfile changes` - pr_agent:The PR contains changes in the Dockerfile ... The list above is eclectic, and aims to give an idea of different possibilities. Define custom labels that are relevant for your repo and use cases. Note that Labels are not mutually exclusive, so you can add multiple label categories. Make sure to provide proper title, and a detailed and well-phrased description for each label, so the tool will know when to suggest it.
Inline File Walkthrough 💎 For enhanced user experience, the `describe` tool can add file summaries directly to the "Files changed" tab in the PR page. This will enable you to quickly understand the changes in each file, while reviewing the code changes (diffs). To enable inline file summary, set `pr_description.inline_file_summary` in the configuration file, possible values are: `'table'`: File changes walkthrough table will be displayed on the top of the "Files changed" tab, in addition to the "Conversation" tab. `true`: A collapsable file comment with changes title and a changes summary for each file in the PR. `false` (default): File changes walkthrough will be added only to the "Conversation" tab.
Utilizing extra instructions The `describe` tool can be configured with extra instructions, to guide the model to a feedback tailored to the needs of your project. Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Notice that the general structure of the description is fixed, and cannot be changed. Extra instructions can change the content or style of each sub-section of the PR description. Examples for extra instructions: `[pr_description] extra_instructions="""- The PR title should be in the format: '<PR type>: <title>' - The title should be short and concise (up to 10 words) - ... """` Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.
More PR-Agent commands To invoke the PR-Agent, add a comment using one of the following commands: /review: Request a review of your Pull Request. /describe: Update the PR title and description based on the contents of the PR. /improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback. /ask <QUESTION>: Ask a question about the PR. /update_changelog: Update the changelog based on the PR's contents. /help_docs <QUESTION>: Given a path to documentation (either for this repository or for a given one), ask a question. /add_docs 💎: Generate docstring for new components introduced in the PR. /generate_labels 💎: Generate labels for the PR based on the PR's contents. /analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component. See the tools guide for more details. To list the possible configuration parameters, add a /config comment.

See the describe usage page for a comprehensive guide on using this tool.

gemini-code-assist · 2026-02-20T08:40:45Z

Summary of Changes

Hello @dasosann, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

이 PR은 로그인 기능을 목업 구현에서 실제 백엔드 API 연결로 전환합니다. serverAction을 활용하여 로그인 요청을 안전하게 처리함으로써 애플리케이션의 인증 기능을 강화하고 프로덕션 준비 상태를 개선합니다.

Highlights

로그인 API 연결: 로그인 액션(loginAction)이 더 이상 목업 데이터를 사용하지 않고 실제 백엔드 API(/api/auth/login)에 연결되도록 업데이트되었습니다.
serverApi 통합: 로그인 요청을 처리하기 위해 serverApi 유틸리티가 도입되어 서버 액션 내에서 안전하게 API 호출을 수행합니다.
에러 처리 개선: API 호출 실패 시 사용자에게 '이메일 혹은 비밀번호가 틀립니다'라는 메시지를 반환하는 예외 처리 로직이 추가되었습니다.

Changelog

lib/actions/loginAction.ts
- serverApi를 사용하여 실제 백엔드 로그인 API를 호출하도록 변경되었습니다.
- 이전의 목업 지연 및 로직이 제거되었습니다.
- API 호출 실패 시 에러 메시지를 반환하는 예외 처리가 추가되었습니다.
- 로그인 성공 시 '로그인 성공' 메시지를 반환하도록 변경되었습니다.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

PR을 통해 로그인 로직을 서버 액션으로 전환한 점은 좋습니다. 하지만 현재 구현에는 몇 가지 치명적인 문제와 개선점이 있습니다.

주요 피드백:

세션 처리 누락 (Critical): 로그인 성공 후 인증 토큰을 처리하여 쿠키에 저장하는 로직이 없어, 실제 로그인 상태가 유지되지 않습니다.
입력값 유효성 검사 부재 (High): 이메일, 비밀번호 등 사용자 입력에 대한 서버 측 유효성 검사가 없어 안정성과 보안에 취약합니다.
미흡한 오류 처리 (High): 모든 오류를 동일한 메시지로 처리하여 사용자 경험을 해치고 디버깅을 어렵게 만듭니다.

아래 리뷰 댓글에서 각 항목에 대한 자세한 설명과 개선 방안을 제안했습니다. 특히 세션 처리 문제는 로그인 기능의 핵심이므로 반드시 해결이 필요합니다.

lib/actions/loginAction.ts

gemini-code-assist · 2026-02-20T08:44:20Z

lib/actions/loginAction.ts

+  } catch {
+    return { success: false, message: "이메일 혹은 비밀번호가 틀립니다" };
  }


현재 catch 블록은 모든 오류를 '이메일 혹은 비밀번호가 틀립니다'라는 단일 메시지로 처리하고 있습니다. 네트워크 오류나 서버 내부 오류(500 등)가 발생했을 때도 사용자는 아이디/비밀번호가 틀렸다고 오인하게 됩니다. 이는 좋지 않은 사용자 경험을 제공하며 디버깅을 어렵게 만듭니다.

오류 객체를 받아 서버에 로깅하고, 사용자에게는 보다 일반적인 오류 메시지를 보여주는 것이 바람직합니다. 추후 axios의 isAxiosError를 사용하여 오류 종류에 따라 메시지를 분기하는 것을 권장합니다.

Suggested change

} catch {

return { success: false, message: "이메일 혹은 비밀번호가 틀립니다" };

}

} catch (error) {

console.error("Login Action Error:", error);

return { success: false, message: "로그인 중 오류가 발생했습니다. 잠시 후 다시 시도해주세요." };

}

ㅇㅋ반영

feat: 로그인 api 연결 serverAction으로

9032729

qodo-code-review bot added the enhancement New feature or request label Feb 20, 2026

gemini-code-assist bot reviewed Feb 20, 2026

View reviewed changes

fix: 로그인 오류 처리 개선 및 예외 로깅 추가

af4296f

dasosann merged commit bb1f939 into main Feb 20, 2026
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

feat: 로그인 api 연결 serverAction으로#29

feat: 로그인 api 연결 serverAction으로#29
dasosann merged 2 commits intomainfrom
feat/login-api

dasosann commented Feb 20, 2026 •

edited by qodo-code-review bot

Loading

Uh oh!

gemini-code-assist bot commented Feb 20, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist bot Feb 20, 2026

Uh oh!

dasosann Feb 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

-  } catch {
-    return { success: false, message: "이메일 혹은 비밀번호가 틀립니다" };
-  }
+} catch (error) {
+  console.error("Login Action Error:", error);
+  return { success: false, message: "로그인 중 오류가 발생했습니다. 잠시 후 다시 시도해주세요." };
+}

Comments

Conversation

dasosann commented Feb 20, 2026 • edited by qodo-code-review bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Type

Description

Diagram Walkthrough

File Walkthrough

Uh oh!

gemini-code-assist bot commented Feb 20, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist bot Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

dasosann Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

dasosann commented Feb 20, 2026 •

edited by qodo-code-review bot

Loading