Added definitions relevant to radiation damage to cif_core.dic and associated units to templ_enum.cif #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
associated units to templ_enum.cif
vaitkus
reviewed
Feb 7, 2025
| 'neutrons_per_millimetre_squared_per_second' | ||
| "neutron flux density 'neutrons per millimetre squared per second (neutrons * (metres * 10^(-3))^(-2) * (seconds^(-1))'" | ||
|
|
||
| 'megagray' "radiation dose 'megagrays'" |
There was a problem hiding this comment.
Most units seem to be in plural also there are already some exceptions (hertz, etc.). I have no strong opinion on this.
There was a problem hiding this comment.
P.S. This is just a general notice, so if it blocking the merge, feel free to close it without my involvement.
added to cif_core.dic.
jamesrhester
approved these changes
Feb 12, 2025
vaitkus
reviewed
Feb 21, 2025
| _name.category_id diffrn | ||
| _name.object_id total_dose | ||
| _type.purpose Number | ||
| _type.source Recorded |
There was a problem hiding this comment.
Based on discussion in #513, this should probably be changed to a Measurand and a corresponded S.U. item should be added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Definitions suggested by the electron diffraction (cif_ed) group and reviewed via coredmg mailing list and input from Elspeth Garman.