Skip to content
This repository has been archived by the owner on Jun 16, 2021. It is now read-only.

All tasks completed #19

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

All tasks completed #19

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 29, 2020 •
edited by ghost
Loading

CSOC Task 1 Submission

I have completed the following tasks

  • Login
  • auth_required.js and no_auth_required.js
  • Add Task
  • Get Tasks
  • Edit Task
  • Delete Task

numberbee7070 and others added 2 commits April 29, 2020 15:27
@nishantwrp
Copy link
Member

Hi @yashking007 ,
I went through your app. Here are some suggestions.

  • There is no error when user doesn't enter username and tries to login.
  • No error when user doesn't enter a task while adding.
  • In EDIT and DELETE complete list of tasks shouldn't be fetched again.
  • The value should be of the current task while editing.

Your score has been updated in the leaderboard.

@nishantwrp nishantwrp added the Judged The Pull Requests which are judged label May 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Judged The Pull Requests which are judged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nishantwrp @numberbee7070