Skip to content
This repository has been archived by the owner on Jun 16, 2021. It is now read-only.

all tasks completed #24

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

all tasks completed #24

wants to merge 3 commits into from

Conversation

sanyud24
Copy link

@sanyud24 sanyud24 commented Apr 29, 2020

CSOC Task 1 Submission

I have completed the following tasks

  • Login
  • auth_required.js and no_auth_required.js
  • Add Task
  • Get Tasks
  • Edit Task
  • Delete Task

@sanyud24 sanyud24 closed this Apr 29, 2020
@sanyud24 sanyud24 reopened this Apr 29, 2020
@sanyud24 sanyud24 changed the title done main.js......no_auth_required.js, auth_required.js fixing init.js Apr 29, 2020
@sanyud24 sanyud24 changed the title fixing init.js all tasks completed Apr 29, 2020
@nishantwrp
Copy link
Member

Hi @sanyud24,
I have gone through your app. Here are some suggestions.

  • When adding a task. The previous tasks get appending again. Same problem with delete, edit.
  • The task added should be erased when the task is added.
  • The edit input box should have the same value as the current task.
  • Don't fetch all tasks again on DELETE and EDIT

Your score has been updated in the leaderboard.

@nishantwrp nishantwrp added the Judged The Pull Requests which are judged label May 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Judged The Pull Requests which are judged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants